Export-DbaCsv - Fix table-name validation regression (review of #10314)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: potatoqualitee

docs/trackers/features/commit-bug-review-TRACKER.md

@@ -123,7 +123,7 @@ Find real bugs (logic errors, null refs, incorrect behavior) and fix them. Skip
 | b2f217f47 | Invoke-TlsWebRequest - Auto-detect system proxy (#10310) | DONE | Preserved configured proxies without Address members, skipped explicit -Proxy overrides, and added regression coverage. |
 | 1662d73a6 | New-DbaDatabase - Support Azure Blob Storage paths for data and log files (#10315) | DONE | Preserved rooted Data/Log paths for validation while still trimming file names; added unit regression tests. |
 | 241a118ce | Test-DbaDbCompression, Get-DbaDbPageInfo - Normalize table names via Get-ObjectNameParts (#10313) | DONE | Preserved schema-/database-qualified table matching and escaped SQL literals; added unit regression tests. |
-| 14a47a26c | Export-DbaCsv, Export-DbaDacPackage - Normalize table/schema names via Get-ObjectNameParts (#10314) | PENDING | |
+| 14a47a26c | Export-DbaCsv, Export-DbaDacPackage - Normalize table/schema names via Get-ObjectNameParts (#10314) | DONE | Export-DbaCsv invalid-name handling was already fixed by follow-up 74a2d1ae1; this review added Export-DbaDacPackage table-name validation and a unit regression test.
 | fe639f6e6 | Remove-DbaDbTableData - Normalize table name via Get-ObjectNameParts (#10316) | PENDING | |
 | 070d2ee7f | Fix AppVeyor dbatools.library cache miss by installing to AllUsers scope (#10335) | PENDING | |
 | e3f6cc121 | Fix test for Invoke-DbaAdvancedUpdate (#10334) | PENDING | |

public/Export-DbaDacPackage.ps1

@@ -186,6 +186,10 @@ function Export-DbaDacPackage {
             foreach ($tableItem in $Table) {
                 # Use Get-ObjectNameParts to correctly handle bracketed names like [Gross.Table.Name]
                 $nameParts = Get-ObjectNameParts -ObjectName $tableItem
+                if (-not $nameParts.Parsed -or -not $nameParts.Name) {
+                    Stop-Function -Message "Table value '$tableItem' is not a valid one-, two-, or three-part name. Use bracket quoting for names that contain periods."
+                    return
+                }
                 if ($nameParts.Schema) {
                     $schemaName = $nameParts.Schema
                 } else {
@@ -224,7 +228,7 @@ WHERE database_id > 4  -- Exclude system databases (master=1, tempdb=2, model=3,
   AND state = 0        -- Only ONLINE databases (OnlyAccessible equivalent)
 "@
 
-            $sqlParams = @{}
+            $sqlParams = @{ }
 
             # Add ExcludeDatabase filter if specified (using parameterized queries to prevent SQL injection)
             if ($ExcludeDatabase) {
@@ -369,4 +373,4 @@ WHERE database_id > 4  -- Exclude system databases (master=1, tempdb=2, model=3,
             }
         }
     }
-}
+}

tests/Export-DbaDacPackage.Tests.ps1

@@ -1,6 +1,6 @@
 #Requires -Module @{ ModuleName="Pester"; ModuleVersion="5.0" }
 param(
-    $ModuleName  = "dbatools",
+    $ModuleName = "dbatools",
     $CommandName = "Export-DbaDacPackage",
     $PSDefaultParameterValues = $TestConfig.Defaults
 )
@@ -30,6 +30,31 @@ Describe $CommandName -Tag UnitTests {
     }
 }
 
+Describe $CommandName -Tag UnitTests {
+    InModuleScope dbatools {
+        Context "Table validation" {
+            BeforeEach {
+                Mock Test-ExportDirectory { }
+                Mock Test-FunctionInterrupt { $false }
+                Mock Connect-DbaInstance {
+                    throw "Connect-DbaInstance should not be called for invalid table filters"
+                }
+                Mock Stop-Function {
+                    throw $Message
+                }
+            }
+
+            It "rejects invalid table names before connecting" {
+                {
+                    Export-DbaDacPackage -SqlInstance "sql1" -Database "db1" -Table "a.b.c.d" -Path "C:\temp"
+                } | Should -Throw "*not a valid one-, two-, or three-part name*"
+
+                Should -Invoke Connect-DbaInstance -Times 0 -Exactly
+            }
+        }
+    }
+}
+
 Describe $CommandName -Tag IntegrationTests {
     BeforeAll {
         # We want to run all commands in the BeforeAll block with EnableException to ensure that the test fails if the setup fails.