Set-DbaDbCompression - Fix indexed view metadata for compression output (review of #10248)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: potatoqualitee

docs/trackers/features/commit-bug-review-TRACKER.md

@@ -69,7 +69,7 @@ Find real bugs (logic errors, null refs, incorrect behavior) and fix them. Skip
 | 6084ecbe5 | Get-DbaLastBackup - Add -ExcludeReplica switch for AlwaysOn preferred backup replica filtering (#10240) | DONE | Fixed empty filtered-set fallback that queried all backup history; added unit regression test. |
 | fe26c8764 | Export-DbaInstance - Wire up IncludeDbMasterKey to export certs and master keys (#10251) | DONE | Fixed FileInfo output contract and staged remote cert/master-key exports back into the local export folder; added unit regression test. |
 | 0ee03fc32 | New-DbaAgentJobStep - Fix OnFailAction ValidateSet order to match actual default (#10244) | DONE | Reviewed parameter metadata-only ValidateSet reorder; no bugs found. |
-| 63c906f9d | Set-DbaDbCompression - Add SortInTempDB parameter and fix views T-SQL bug (#10248) | PENDING | |
+| 63c906f9d | Set-DbaDbCompression - Add SortInTempDB parameter and fix views T-SQL bug (#10248) | DONE | Fixed indexed-view output/error metadata to use the view name instead of a stale table reference; added integration regression test. |
 | 4d1a9d80c | v2.7.27 | DONE | version bump - skip |
 | 232395207 | Set-DbaPrivilege, Get-DbaPrivilege - Add CreateGlobalObjects privilege support (#10235) | PENDING | |
 | 099624061 | Get-DbaDbRestoreHistory - Add BackupStartDate, StopAt, and LastRestorePoint columns (#10249) | PENDING | |

public/Set-DbaDbCompression.ps1

@@ -360,6 +360,7 @@ function Set-DbaDbCompression {
                             }
                         }
                         foreach ($index in $($server.Databases[$($db.name)].Views | Where-Object { $_.Indexes }).Indexes) {
+                            $parentView = $index.Parent
                             foreach ($p in $($index.PhysicalPartitions | Where-Object { $_.DataCompression -ne $CompressionType })) {
                                 Write-Message -Level Verbose -Message "Compressing $($index.IndexType) $($index.Name) Partition $($p.PartitionNumber)"
                                 try {
@@ -383,15 +384,15 @@ function Set-DbaDbCompression {
                                         $index.Rebuild()
                                     }
                                 } catch {
-                                    Stop-Function -Message "Compression failed for $instance - $db - table $($obj.Schema).$($obj.Name) - index $($index.Name) - partition $($p.PartitionNumber)" -Target $db -ErrorRecord $_ -Continue
+                                    Stop-Function -Message "Compression failed for $instance - $db - view $($parentView.Schema).$($parentView.Name) - index $($index.Name) - partition $($p.PartitionNumber)" -Target $db -ErrorRecord $_ -Continue
                                 }
                                 [PSCustomObject]@{
                                     ComputerName                  = $server.ComputerName
                                     InstanceName                  = $server.ServiceName
                                     SqlInstance                   = $server.DomainInstanceName
                                     Database                      = $db.Name
-                                    Schema                        = $obj.Schema
-                                    TableName                     = $obj.Name
+                                    Schema                        = $parentView.Schema
+                                    TableName                     = $parentView.Name
                                     IndexName                     = $index.Name
                                     Partition                     = $p.PartitionNumber
                                     IndexID                       = $index.Id

tests/Set-DbaDbCompression.Tests.ps1

@@ -1,6 +1,6 @@
 #Requires -Module @{ ModuleName="Pester"; ModuleVersion="5.0" }
 param(
-    $ModuleName  = "dbatools",
+    $ModuleName = "dbatools",
     $CommandName = "Set-DbaDbCompression",
     $PSDefaultParameterValues = $TestConfig.Defaults
 )
@@ -35,12 +35,29 @@ Describe $CommandName -Tag IntegrationTests {
         $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
         $dbName = "dbatoolsci_test_$(Get-Random)"
+        $indexedViewName = "dbatoolsci_syscolview"
+        $indexedViewIndexName = "CL_dbatoolsci_syscolview"
         $server = Connect-DbaInstance -SqlInstance $TestConfig.InstanceSingle
         $null = $server.Query("Create Database [$dbName]")
         $null = $server.Query("select * into syscols from sys.all_columns
                                 select * into sysallparams from sys.all_parameters
                                 create clustered index CL_sysallparams on sysallparams (object_id)
                                 create nonclustered index NC_syscols on syscols (precision) include (collation_name)", $dbName)
+        $null = $server.Query("SET ANSI_NULLS ON;
+                               SET QUOTED_IDENTIFIER ON;
+                               EXEC sys.sp_executesql N'CREATE VIEW dbo.[$indexedViewName]
+                               WITH SCHEMABINDING
+                               AS
+                               SELECT object_id, column_id
+                               FROM dbo.syscols'", $dbName)
+        $null = $server.Query("SET ANSI_NULLS ON;
+                               SET ANSI_PADDING ON;
+                               SET ANSI_WARNINGS ON;
+                               SET ARITHABORT ON;
+                               SET CONCAT_NULL_YIELDS_NULL ON;
+                               SET QUOTED_IDENTIFIER ON;
+                               SET NUMERIC_ROUNDABORT OFF;
+                               CREATE UNIQUE CLUSTERED INDEX [$indexedViewIndexName] ON dbo.[$indexedViewName] (object_id, column_id)", $dbName)
 
         # Get InputObject for testing
         $inputObject = Test-DbaDbCompression -SqlInstance $TestConfig.InstanceSingle -Database $dbName
@@ -161,4 +178,20 @@ Describe $CommandName -Tag IntegrationTests {
             }
         }
     }
-}
+
+    Context "Command returns indexed view metadata when rebuilding to None" {
+        BeforeAll {
+            $null = Set-DbaDbCompression -SqlInstance $TestConfig.InstanceSingle -Database $dbName -CompressionType Page
+            $indexedViewResults = Set-DbaDbCompression -SqlInstance $TestConfig.InstanceSingle -Database $dbName -CompressionType None |
+                Where-Object IndexName -eq $indexedViewIndexName
+        }
+
+        It "Should return the indexed view schema and name" {
+            $indexedViewResults | Should -Not -BeNullOrEmpty
+            foreach ($row in $indexedViewResults) {
+                $row.Schema | Should -Be "dbo"
+                $row.TableName | Should -Be $indexedViewName
+            }
+        }
+    }
+}