Find-DbaObject - Fix missing database DDL trigger matches (review of #10321)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: potatoqualitee

docs/trackers/features/commit-bug-review-TRACKER.md

@@ -137,7 +137,7 @@ Find real bugs (logic errors, null refs, incorrect behavior) and fix them. Skip
 | a38bc6b35 | Get-DbaDbIdentity, Set-DbaDbIdentity, Invoke-DbaDbDbccUpdateUsage - Normalize table names (#10318) | DONE | Fixed escaped-bracket table name regression and added unit regression tests. |
 | 9899bd274 | Copy-DbaDbTableData - Add -ScriptingOptionsObject parameter (#10317) | DONE | Propagated ScriptingOptionsObject to Copy-DbaDbViewData and added unit coverage. |
 | 0c486b964 | Backup-DbaDbCertificate: Don't use decryption password if cert encrypted by master key (#10329) | DONE | Reviewed SMO export overload selection for master-key-encrypted certs; no bugs found. |
-| db77a3476 | Find-DbaObject - Add unified command to search database objects by name (#10321) | PENDING | |
+| db77a3476 | Find-DbaObject - Add unified command to search database objects by name (#10321) | DONE | Added database DDL trigger name search via sys.triggers and covered it with an integration regression test. |
 | 6416b4e91 | Add Compare-DbaLogin command (#10319) | PENDING | |
 | bee08f8e7 | Copy-DbaSsisCatalog - Add standard MigrationObject output, integrate with Start-DbaMigration (#10311) | PENDING | |
 | 21e4795ee | Get-DbaService - Add PowerBI Report Server detection (#10298) | PENDING | |

public/Find-DbaObject.ps1

@@ -44,7 +44,7 @@ function Find-DbaObject {
         - ScalarFunction: Scalar-valued functions (sys.objects type FN)
         - TableValuedFunction: Inline and multi-statement table-valued functions (sys.objects type IF/TF)
         - Synonym: Synonyms (sys.objects type SN)
-        - Trigger: SQL triggers (sys.objects type TR)
+        - Trigger: Object-level DML triggers plus database DDL SQL triggers
         - All: All of the above (default)
 
     .PARAMETER IncludeColumns
@@ -86,7 +86,7 @@ function Find-DbaObject {
         - ComputerName: The computer name of the SQL Server instance
         - SqlInstance: The SQL Server instance name
         - Database: The database containing the matched object
-        - Schema: The schema of the matched object
+        - Schema: The schema of the matched object (null for database DDL triggers)
         - Name: The name of the matched object
         - ObjectType: The SQL Server type description (e.g., USER_TABLE, VIEW, SQL_STORED_PROCEDURE)
         - MatchType: "ObjectName" when the object name matched, "ColumnName" when a column name matched
@@ -159,7 +159,9 @@ function Find-DbaObject {
             $typeFilter = ($typeCodes | Select-Object -Unique) -join ", "
         }
 
+        $includeDatabaseTriggers = "All" -in $ObjectType -or "Trigger" -in $ObjectType
         $sysFilter = if ($IncludeSystemObjects) { "" } else { "AND o.is_ms_shipped = 0" }
+        $triggerFilter = if ($IncludeSystemObjects) { "" } else { "AND tr.is_ms_shipped = 0" }
 
         $sqlObjects = "
             SELECT
@@ -173,6 +175,22 @@ function Find-DbaObject {
             WHERE o.type IN ($typeFilter)
             $sysFilter"
 
+        if ($includeDatabaseTriggers) {
+            $sqlObjects += "
+            UNION ALL
+            SELECT
+                CAST(NULL AS sysname)            AS SchemaName,
+                tr.name                          AS ObjectName,
+                RTRIM(tr.type)                   AS ObjectTypeCode,
+                tr.type_desc                     AS ObjectType,
+                tr.create_date                   AS CreateDate,
+                tr.modify_date                   AS LastModified
+            FROM sys.triggers tr
+            WHERE tr.parent_class = 0
+            AND tr.type = 'TR'
+            $triggerFilter"
+        }
+
         $sqlColumns = "
             SELECT
                 OBJECT_SCHEMA_NAME(c.object_id) AS SchemaName,

tests/Find-DbaObject.Tests.ps1

@@ -63,6 +63,15 @@ CREATE PROCEDURE dbo.usp_GetServiceOrders
 AS
     SELECT * FROM dbo.ServiceOrder;
 GO
+
+CREATE TRIGGER trg_ServiceAudit
+ON DATABASE
+FOR CREATE_TABLE
+AS
+BEGIN
+    SET NOCOUNT ON;
+END;
+GO
 "@
         $splatCreateObjects = @{
             SqlInstance = $TestConfig.InstanceSingle
@@ -124,6 +133,19 @@ GO
             $results.Name | Should -Contain "usp_GetServiceOrders"
         }
 
+        It "Should find database DDL triggers whose names match the pattern" {
+            $splatFind = @{
+                SqlInstance = $TestConfig.InstanceSingle
+                Database    = $testDbName
+                Pattern     = "ServiceAudit"
+                ObjectType  = "Trigger"
+            }
+            $results = Find-DbaObject @splatFind
+            $results | Should -Not -BeNullOrEmpty
+            $results.Name | Should -Contain "trg_ServiceAudit"
+            $results.Schema | Should -BeNullOrEmpty
+        }
+
         It "Should return MatchType of ObjectName for object name matches" {
             $splatFind = @{
                 SqlInstance = $TestConfig.InstanceSingle