appveyor fixes

Author: potatoqualitee

appveyor.yml

@@ -12,7 +12,7 @@ cache:
   - C:\ProgramData\chocolatey\lib -> appveyor.yml
   - C:\Program Files\WindowsPowerShell\Modules\PSScriptAnalyzer -> appveyor.yml
   - C:\Program Files\WindowsPowerShell\Modules\Pester -> appveyor.yml
-  - C:\Program Files\WindowsPowerShell\Modules\dbatools.library -> dbatools.psd1
+  - C:\Program Files\WindowsPowerShell\Modules\dbatools.library -> .github/dbatools-library-version.json
 
 #shallow_clone: true
 clone_depth: 100
@@ -78,7 +78,7 @@ before_test:
   # turn tests directory (at least) to CRLF, as it's faster to do this on the zipball rather than checking out the repo
   - cmd: pushd C:\github\dbatools\tests & unix2dos -q  *.ps1 & popd
   # don't clown -- for some reason it's just not installing the library
-  - ps: if (-not(Test-Path 'C:\Program Files\WindowsPowerShell\Modules\dbatools.library')) { Install-Module -Name dbatools.library -AllowPrerelease -Force | Out-Null }
+  # dbatools.library is now installed via centralized method in appveyor.prep.ps1
   # grab appveyor lab files and needed requirements for tests in CI
   - ps: .\Tests\appveyor.prep.ps1
 

tests/appveyor.prep.ps1

@@ -30,7 +30,24 @@ if (-not(Test-Path 'C:\Program Files\WindowsPowerShell\Modules\PSScriptAnalyzer\
 #Get dbatools.library
 Write-Host -Object "appveyor.prep: Install dbatools.library" -ForegroundColor DarkGreen
 # Use centralized version management for dbatools.library installation
-& "$PSScriptRoot\..\github\scripts\install-dbatools-library.ps1" | Out-Null
+& "$PSScriptRoot\..\.github\scripts\install-dbatools-library.ps1"
+# Validate that the correct version was installed
+$expectedVersion = (Get-Content '.github/dbatools-library-version.json' | ConvertFrom-Json).version
+$installedModule = Get-Module dbatools.library -ListAvailable | Sort-Object Version -Descending | Select-Object -First 1
+
+if (-not $installedModule) {
+    throw "dbatools.library module was not installed successfully"
+}
+
+Write-Host -Object "appveyor.prep: Expected version: $expectedVersion" -ForegroundColor Green
+Write-Host -Object "appveyor.prep: Installed version: $($installedModule.Version)" -ForegroundColor Green
+
+# Verify the version matches (allowing for version format differences)
+if ($installedModule.Version.ToString() -notmatch [regex]::Escape($expectedVersion.Split('-')[0])) {
+    Write-Warning "Installed version $($installedModule.Version) may not match expected version $expectedVersion"
+} else {
+    Write-Host -Object "appveyor.prep: Version validation successful" -ForegroundColor Green
+}
 
 #Get Pester (to run tests) - choco isn't working onall scenarios, weird
 Write-Host -Object "appveyor.prep: Install Pester4" -ForegroundColor DarkGreen