New-DbaDbMailAccount - Fix conflicting SMTP authentication validation (review of #10257)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: potatoqualitee

docs/trackers/features/commit-bug-review-TRACKER.md

@@ -73,7 +73,7 @@ Find real bugs (logic errors, null refs, incorrect behavior) and fix them. Skip
 | 4d1a9d80c | v2.7.27 | DONE | version bump - skip |
 | 232395207 | Set-DbaPrivilege, Get-DbaPrivilege - Add CreateGlobalObjects privilege support (#10235) | DONE | Fixed empty privilege-entry updates so Set-DbaPrivilege still grants rights when secedit exports a blank line; added unit regression test. |
 | 099624061 | Get-DbaDbRestoreHistory - Add BackupStartDate, StopAt, and LastRestorePoint columns (#10249) | DONE | Fixed LastRestorePoint so StopAt is used whenever specified; added unit regression test. |
-| 4f1e56ce4 | New-DbaDbMailAccount, Set-DbaDbMailAccount - Add Port, SSL, and authentication parameters (#10257) | PENDING | |
+| 4f1e56ce4 | New-DbaDbMailAccount, Set-DbaDbMailAccount - Add Port, SSL, and authentication parameters (#10257) | DONE | Added validation to reject conflicting SMTP authentication modes and incomplete credential pairs; added unit regression tests. |
 | 8218d327e | Restore-DbaDatabase, Invoke-DbaAdvancedRestore - Add ErrorBrokerConversations parameter (#10253) | PENDING | |
 | 9a4e4bacb | Connect-DbaInstance - Set NonPooledConnection on ServerConnection (#10260) | PENDING | |
 | a0ab78a66 | Get-DbaCmObject - Apply CimOperationTimeout to all CIM connections (#10252) | PENDING | |

public/New-DbaDbMailAccount.ps1

@@ -160,6 +160,7 @@ function New-DbaDbMailAccount {
         [string]$EmailAddress,
         [string]$ReplyToAddress,
         [string]$MailServer,
+        [ValidateRange(1, 65535)]
         [int]$Port,
         [switch]$EnableSSL,
         [switch]$UseDefaultCredentials,
@@ -169,6 +170,16 @@ function New-DbaDbMailAccount {
         [switch]$EnableException
     )
     process {
+        if ($UseDefaultCredentials.IsPresent -and (Test-Bound -ParameterName UserName, Password)) {
+            Stop-Function -Category InvalidArgument -Message "You cannot specify -UseDefaultCredentials with -UserName or -Password."
+            return
+        }
+
+        if (Test-Bound -ParameterName UserName, Password -Min 1 -Max 1) {
+            Stop-Function -Category InvalidArgument -Message "You must specify both -UserName and -Password together."
+            return
+        }
+
         foreach ($instance in $SqlInstance) {
             try {
                 $server = Connect-DbaInstance -SqlInstance $instance -SqlCredential $SqlCredential -MinimumVersion 10
@@ -224,4 +235,4 @@ function New-DbaDbMailAccount {
             }
         }
     }
-}
+}

public/Set-DbaDbMailAccount.ps1

@@ -137,6 +137,7 @@ function Set-DbaDbMailAccount {
         [string]$EmailAddress,
         [string]$ReplyToAddress,
         [string]$NewMailServerName,
+        [ValidateRange(1, 65535)]
         [int]$Port,
         [switch]$EnableSSL,
         [switch]$UseDefaultCredentials,
@@ -145,6 +146,11 @@ function Set-DbaDbMailAccount {
         [switch]$EnableException
     )
     process {
+        if ($UseDefaultCredentials.IsPresent -and (Test-Bound -ParameterName UserName, Password)) {
+            Stop-Function -Category InvalidArgument -Message "You cannot specify -UseDefaultCredentials with -UserName or -Password."
+            return
+        }
+
         foreach ($instance in $SqlInstance) {
             $InputObject += Get-DbaDbMailAccount -SqlInstance $instance -SqlCredential $SqlCredential -Account $Account -EnableException:$EnableException
         }
@@ -197,4 +203,4 @@ function Set-DbaDbMailAccount {
             }
         }
     }
-}
+}

tests/New-DbaDbMailAccount.Tests.ps1

@@ -1,6 +1,6 @@
 #Requires -Module @{ ModuleName="Pester"; ModuleVersion="5.0" }
 param(
-    $ModuleName  = "dbatools",
+    $ModuleName = "dbatools",
     $CommandName = "New-DbaDbMailAccount",
     $PSDefaultParameterValues = $TestConfig.Defaults
 )
@@ -30,6 +30,27 @@ Describe $CommandName -Tag UnitTests {
             Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $hasParameters | Should -BeNullOrEmpty
         }
     }
+
+    InModuleScope dbatools {
+        Context "Input validation" {
+            It "Should call Stop-Function when default credentials are combined with SMTP credentials" {
+                Mock Stop-Function { }
+                $securePassword = ConvertTo-SecureString "P@ssw0rd!" -AsPlainText -Force
+
+                New-DbaDbMailAccount -SqlInstance "sql1" -Account "alerts" -EmailAddress "alerts@contoso.com" -UseDefaultCredentials -UserName "alerts@contoso.com" -Password $securePassword | Should -BeNullOrEmpty
+
+                Should -Invoke Stop-Function -Times 1 -Exactly
+            }
+
+            It "Should call Stop-Function when only one SMTP credential value is provided" {
+                Mock Stop-Function { }
+
+                New-DbaDbMailAccount -SqlInstance "sql1" -Account "alerts" -EmailAddress "alerts@contoso.com" -UserName "alerts@contoso.com" | Should -BeNullOrEmpty
+
+                Should -Invoke Stop-Function -Times 1 -Exactly
+            }
+        }
+    }
 }
 
 Describe $CommandName -Tag IntegrationTests {

tests/Set-DbaDbMailAccount.Tests.ps1

@@ -1,6 +1,6 @@
 #Requires -Module @{ ModuleName="Pester"; ModuleVersion="5.0" }
 param(
-    $ModuleName  = "dbatools",
+    $ModuleName = "dbatools",
     $CommandName = "Set-DbaDbMailAccount",
     $PSDefaultParameterValues = $TestConfig.Defaults
 )
@@ -30,6 +30,19 @@ Describe $CommandName -Tag UnitTests {
             Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $hasParameters | Should -BeNullOrEmpty
         }
     }
+
+    InModuleScope dbatools {
+        Context "Input validation" {
+            It "Should call Stop-Function when default credentials are combined with SMTP credentials" {
+                Mock Stop-Function { }
+                $securePassword = ConvertTo-SecureString "P@ssw0rd!" -AsPlainText -Force
+
+                Set-DbaDbMailAccount -SqlInstance "sql1" -Account "alerts" -UseDefaultCredentials -UserName "alerts@contoso.com" -Password $securePassword | Should -BeNullOrEmpty
+
+                Should -Invoke Stop-Function -Times 1 -Exactly
+            }
+        }
+    }
 }
 
 Describe $CommandName -Tag IntegrationTests {
@@ -126,4 +139,4 @@ Describe $CommandName -Tag IntegrationTests {
             $mailServer.EnableSsl | Should -Be $false
         }
     }
-}
+}