Get-DbaDbRestoreHistory - Fix LastRestorePoint fallback logic (review of #10249)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: potatoqualitee

docs/trackers/features/commit-bug-review-TRACKER.md

@@ -72,7 +72,7 @@ Find real bugs (logic errors, null refs, incorrect behavior) and fix them. Skip
 | 63c906f9d | Set-DbaDbCompression - Add SortInTempDB parameter and fix views T-SQL bug (#10248) | DONE | Fixed indexed-view output/error metadata to use the view name instead of a stale table reference; added integration regression test. |
 | 4d1a9d80c | v2.7.27 | DONE | version bump - skip |
 | 232395207 | Set-DbaPrivilege, Get-DbaPrivilege - Add CreateGlobalObjects privilege support (#10235) | DONE | Fixed empty privilege-entry updates so Set-DbaPrivilege still grants rights when secedit exports a blank line; added unit regression test. |
-| 099624061 | Get-DbaDbRestoreHistory - Add BackupStartDate, StopAt, and LastRestorePoint columns (#10249) | PENDING | |
+| 099624061 | Get-DbaDbRestoreHistory - Add BackupStartDate, StopAt, and LastRestorePoint columns (#10249) | DONE | Fixed LastRestorePoint so StopAt is used whenever specified; added unit regression test. |
 | 4f1e56ce4 | New-DbaDbMailAccount, Set-DbaDbMailAccount - Add Port, SSL, and authentication parameters (#10257) | PENDING | |
 | 8218d327e | Restore-DbaDatabase, Invoke-DbaAdvancedRestore - Add ErrorBrokerConversations parameter (#10253) | PENDING | |
 | 9a4e4bacb | Connect-DbaInstance - Set NonPooledConnection on ServerConnection (#10260) | PENDING | |

public/Get-DbaDbRestoreHistory.ps1

@@ -86,7 +86,7 @@ function Get-DbaDbRestoreHistory {
         - BackupStartDate: Timestamp when the backup operation started
         - BackupFinishDate: Timestamp when the backup operation completed
         - StopAt: The point-in-time stop value specified during the restore operation (NULL if not specified)
-        - LastRestorePoint: The effective point in time the database was restored to (StopAt if specified and earlier than BackupStartDate, otherwise BackupStartDate)
+        - LastRestorePoint: The effective point in time the database was restored to (StopAt if specified, otherwise BackupStartDate)
 
         All properties from the underlying DataRow object are accessible using Select-Object *.
 
@@ -188,10 +188,7 @@ function Get-DbaDbRestoreHistory {
                     bs.backup_finish_date,
                     bs.backup_finish_date AS BackupFinishDate,
                     rsh.stop_at AS StopAt,
-                    CASE
-                        WHEN COALESCE(rsh.stop_at, '9999-12-31') < bs.backup_start_date THEN rsh.stop_at
-                        ELSE bs.backup_start_date
-                    END AS LastRestorePoint
+                    COALESCE(rsh.stop_at, bs.backup_start_date) AS LastRestorePoint
                     "
                 }
 

tests/Get-DbaDbRestoreHistory.Tests.ps1

@@ -1,6 +1,6 @@
 #Requires -Module @{ ModuleName="Pester"; ModuleVersion="5.0" }
 param(
-    $ModuleName  = "dbatools",
+    $ModuleName = "dbatools",
     $CommandName = "Get-DbaDbRestoreHistory",
     $PSDefaultParameterValues = $TestConfig.Defaults
 )
@@ -27,6 +27,47 @@ Describe $CommandName -Tag UnitTests {
 
 }
 
+Describe $CommandName -Tag UnitTests {
+    InModuleScope "dbatools" {
+        BeforeAll {
+            $script:capturedQuery = $null
+            $script:mockServer = [PSCustomObject]@{
+                ComputerName       = "sql01"
+                ServiceName        = "MSSQLSERVER"
+                DomainInstanceName = "sql01"
+                ConnectionContext  = [PSCustomObject]@{ }
+            }
+            Add-Member -InputObject $script:mockServer.ConnectionContext -Name ExecuteWithResults -MemberType ScriptMethod -Value {
+                param($Query)
+                $script:capturedQuery = $Query
+                [PSCustomObject]@{
+                    Tables = [PSCustomObject]@{
+                        Rows = @()
+                    }
+                }
+            } -Force
+
+            Mock Connect-DbaInstance {
+                $script:mockServer
+            }
+        }
+
+        Context "LastRestorePoint query generation" {
+            BeforeEach {
+                $script:capturedQuery = $null
+            }
+
+            It "uses StopAt whenever it is present" {
+                $null = Get-DbaDbRestoreHistory -SqlInstance "sql01" -Database "db1"
+                $normalizedQuery = $script:capturedQuery -replace "\s+", " "
+
+                $normalizedQuery | Should -Match "COALESCE\(rsh\.stop_at,\s*bs\.backup_start_date\)\s+AS\s+LastRestorePoint"
+                $normalizedQuery | Should -Not -Match "COALESCE\(rsh\.stop_at,\s*'9999-12-31'\)\s*<\s*bs\.backup_start_date"
+            }
+        }
+    }
+}
+
 Describe $CommandName -Tag IntegrationTests {
 
     BeforeAll {