Import-DbaXESessionTemplate - Add event_file target when TargetFilePath specified but template has none#10250
Merged
Conversation
…th specified but template has none Fixes #7727: TargetFilePath and TargetFileMetadataPath parameters were silently ignored when the XE session template did not contain an event_file target (e.g. templates using ring_buffer like 'Connection Detail Tracking'). Now an event_file target is injected into the XML when TargetFilePath is provided but no event_file target exists in the template. Additional fixes: - Linux path bug: removed erroneous property access that evaluated to null - TargetFileMetadataPath is now only applied when that parameter is actually bound - Misleading verbose message no longer shown for TargetFileMetadataPath when not specified (do Import-DbaXESessionTemplate) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
Member
|
Very nice, appreciate all these |
potatoqualitee
added a commit
that referenced
this pull request
Apr 10, 2026
…iew of #10250) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7727: TargetFilePath and TargetFileMetadataPath parameters were silently ignored when the XE session template did not contain an event_file target (e.g. templates using ring_buffer like 'Connection Detail Tracking'). Now an event_file target is injected into the XML when TargetFilePath is provided but no event_file target exists in the template.
Additional fixes:
Generated with Claude Code