From 053b2e34a186760a74329c70cc35181a26d50dd1 Mon Sep 17 00:00:00 2001
From: "claude[bot]" <41898282+claude[bot]@users.noreply.github.com>
Date: Sun, 15 Mar 2026 18:36:21 +0000
Subject: [PATCH] Import-DbaXESessionTemplate - Add event_file target when
 TargetFilePath specified but template has none

Fixes #7727: TargetFilePath and TargetFileMetadataPath parameters were silently ignored when
the XE session template did not contain an event_file target (e.g. templates using ring_buffer
like 'Connection Detail Tracking'). Now an event_file target is injected into the XML when
TargetFilePath is provided but no event_file target exists in the template.

Additional fixes:
- Linux path bug: removed erroneous property access that evaluated to null
- TargetFileMetadataPath is now only applied when that parameter is actually bound
- Misleading verbose message no longer shown for TargetFileMetadataPath when not specified

(do Import-DbaXESessionTemplate)

Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
---
 public/Import-DbaXESessionTemplate.ps1 | 44 +++++++++++++++++++-------
 1 file changed, 32 insertions(+), 12 deletions(-)

diff --git a/public/Import-DbaXESessionTemplate.ps1 b/public/Import-DbaXESessionTemplate.ps1
index 3ceb0507de68..fb9f39f6b3c6 100644
--- a/public/Import-DbaXESessionTemplate.ps1
+++ b/public/Import-DbaXESessionTemplate.ps1
@@ -177,28 +177,48 @@ function Import-DbaXESessionTemplate {
                     }
                 } else {
                     Write-Message -Level Verbose -Message "TargetFilePath specified, changing all file locations in $file for $instance."
-                    Write-Message -Level Verbose -Message "TargetFileMetadataPath specified, changing all metadata file locations in $file for $instance."
 
                     # Handle whatever people specify
                     $TargetFilePath = $TargetFilePath.TrimEnd("\").TrimEnd("/")
-                    $TargetFileMetadataPath = $TargetFileMetadataPath.TrimEnd("\").TrimEnd("/")
+                    if (Test-Bound -ParameterName TargetFileMetadataPath) {
+                        Write-Message -Level Verbose -Message "TargetFileMetadataPath specified, changing all metadata file locations in $file for $instance."
+                        $TargetFileMetadataPath = $TargetFileMetadataPath.TrimEnd("\").TrimEnd("/")
+                    }
                     if ((Test-HostOSLinux -SqlInstance $server)) {
-                        $TargetFilePath = "$TargetFilePath/".$file.TrimEnd("\").TrimEnd("/")
-                        $TargetFileMetadataPath = "$TargetFileMetadataPath/"
+                        $TargetFilePath = "$TargetFilePath/"
+                        if (Test-Bound -ParameterName TargetFileMetadataPath) {
+                            $TargetFileMetadataPath = "$TargetFileMetadataPath/"
+                        }
                     } else {
                         $TargetFilePath = "$TargetFilePath\"
-                        $TargetFileMetadataPath = "$TargetFileMetadataPath\"
+                        if (Test-Bound -ParameterName TargetFileMetadataPath) {
+                            $TargetFileMetadataPath = "$TargetFileMetadataPath\"
+                        }
                     }
 
-                    # Perform replace
-                    $xelphrase = 'name="filename" value="'
-                    $xemphrase = 'name="metadatafile" value="'
-
                     try {
                         $basename = (Get-ChildItem $file).Basename
-                        $contents = Get-Content $file -ErrorAction Stop
-                        $contents = $contents.Replace($xelphrase, "$xelphrase$TargetFilePath")
-                        $contents = $contents.Replace($xemphrase, "$xemphrase$TargetFileMetadataPath")
+                        $contents = Get-Content $file -Raw -ErrorAction Stop
+
+                        if ($contents -notmatch 'name="event_file"') {
+                            # No event_file target found in template - add one so TargetFilePath is honored
+                            Write-Message -Level Verbose -Message "No event_file target found in template, adding one with TargetFilePath."
+                            if (Test-Bound -ParameterName TargetFileMetadataPath) {
+                                $newTarget = "    <target package=""package0"" name=""event_file""><parameter name=""filename"" value=""$TargetFilePath$basename"" /><parameter name=""metadatafile"" value=""$TargetFileMetadataPath$basename"" /></target>"
+                            } else {
+                                $newTarget = "    <target package=""package0"" name=""event_file""><parameter name=""filename"" value=""$TargetFilePath$basename"" /></target>"
+                            }
+                            $contents = $contents.Replace("</event_session>", "$newTarget</event_session>")
+                        } else {
+                            # Perform replace on existing event_file target parameters
+                            $xelphrase = 'name="filename" value="'
+                            $xemphrase = 'name="metadatafile" value="'
+                            $contents = $contents.Replace($xelphrase, "$xelphrase$TargetFilePath")
+                            if (Test-Bound -ParameterName TargetFileMetadataPath) {
+                                $contents = $contents.Replace($xemphrase, "$xemphrase$TargetFileMetadataPath")
+                            }
+                        }
+
                         $temp = ([System.IO.Path]::GetTempPath()).TrimEnd("").TrimEnd("\").TrimEnd("/")
                         $tempfile = Join-DbaPath $temp $basename
                         $null = Set-Content -Path $tempfile -Value $contents -Encoding UTF8