Skip to content

Update-SqlPermission - Remove unnecessary SqlConnectionObject.Close() calls #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potatoqualitee merged 1 commit into from
Mar 29, 2026
Merged

Update-SqlPermission - Remove unnecessary SqlConnectionObject.Close() calls #10291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions private/functions/Update-SqlPermission.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ function Update-SqlPermission {
}
}

# gotta close because enum repeatedly causes problems with the datareader
$null = $SourceServer.ConnectionContext.SqlConnectionObject.Close()
$null = $DestServer.ConnectionContext.SqlConnectionObject.Close()

# Server Roles: sysadmin, bulklogin, etc
foreach ($role in $SourceServer.Roles) {
$roleName = $role.Name
Expand Down Expand Up @@ -132,9 +128,6 @@ function Update-SqlPermission {
Securables: Connect SQL, View any database, Administer Bulk Operations, etc.
#>

$null = $sourceServer.ConnectionContext.SqlConnectionObject.Close()
$null = $destServer.ConnectionContext.SqlConnectionObject.Close()

$perms = $SourceServer.EnumServerPermissions($loginName)
foreach ($perm in $perms) {
$permState = $perm.PermissionState
Expand Down Expand Up @@ -259,8 +252,6 @@ function Update-SqlPermission {
}
}

$null = $sourceDb.Parent.ConnectionContext.SqlConnectionObject.Close()
$null = $destDb.Parent.ConnectionContext.SqlConnectionObject.Close()
# Remove Connect, Alter Any Assembly, etc
$destPerms = $destDb.EnumDatabasePermissions($newLoginName)
$perms = $sourceDb.EnumDatabasePermissions($loginName)
Expand Down Expand Up @@ -292,9 +283,6 @@ function Update-SqlPermission {
}

# Adding database mappings and securables
$null = $SourceLogin.Parent.ConnectionContext.SqlConnectionObject.Close()
$null = $DestServer.ConnectionContext.SqlConnectionObject.Close()

foreach ($db in $SourceLogin.EnumDatabaseMappings()) {
$dbName = $db.DbName
$destDb = $DestServer.Databases[$dbName]
Expand Down Expand Up @@ -355,8 +343,6 @@ function Update-SqlPermission {
} else {
# Database Roles: db_owner, db_datareader, etc
foreach ($role in $sourceDb.Roles) {
$null = $sourceDb.Parent.ConnectionContext.SqlConnectionObject.Close()
$null = $destDb.Parent.ConnectionContext.SqlConnectionObject.Close()
if ($role.EnumMembers() -contains $loginName) {
$roleName = $role.Name
$destDbRole = $destDb.Roles[$roleName]
Expand All @@ -375,7 +361,6 @@ function Update-SqlPermission {
}
}
# Connect, Alter Any Assembly, etc
$null = $sourceDb.Parent.ConnectionContext.SqlConnectionObject.Close()
$perms = $sourceDb.EnumDatabasePermissions($loginName)
foreach ($perm in $perms) {
$permState = $perm.PermissionState
Expand Down
Loading