Find-DbaInstance - Set TcpConnected=true when SqlConnect succeeds#10325
Closed
andreasjordan wants to merge 1 commit into
Closed
Find-DbaInstance - Set TcpConnected=true when SqlConnect succeeds#10325andreasjordan wants to merge 1 commit into
andreasjordan wants to merge 1 commit into
Conversation
When a SQL connection is established (or reaches the instance with error class < 25), TCP connectivity is proven. Previously TcpConnected would remain false if the TCPPort scan type was not included in ScanType, even though SqlConnect requires TCP. This fixes the test failure when using ScanType Browser, SqlConnect against SQL Server 2025. Fixes #10322 (do Find-DbaInstance) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a SQL connection is established (or reaches the instance with error class < 25), TCP connectivity is proven. Previously TcpConnected would remain false if the TCPPort scan type was not included in ScanType, even though SqlConnect requires TCP.
Fixes #10322
Generated with Claude Code