Fix CI: Node 18.x only, remove e2e/SSR/codecov, CodeQL v3

milanmajchrak · milanmajchrak · commit 52ef6540ab42 · 2026-04-08T13:12:21.000+02:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -44,7 +44,7 @@ jobs:
     strategy:
       # Create a matrix of Node versions to test against (in parallel)
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [18.x]
       # Do NOT exit immediately if one matrix job fails
       fail-fast: false
     # These are the actual CI steps to perform per job
@@ -120,223 +120,5 @@ jobs:
           path: 'coverage/dspace-angular/lcov.info'
           retention-days: 14
 
-      # Login to our Docker registry, so that we can access private Docker images using "docker compose" below.
-      - name: Login to ${{ env.DOCKER_REGISTRY }}
-        uses: docker/login-action@v3
-        with:
-          registry: ${{ env.DOCKER_REGISTRY }}
-          username: ${{ github.repository_owner }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      # Using "docker compose" start backend using CI configuration
-      # and load assetstore from a cached copy
-      - name: Start DSpace REST Backend via Docker (for e2e tests)
-        run: |
-          docker compose -f ./docker/docker-compose-ci.yml up -d
-          docker compose -f ./docker/cli.yml -f ./docker/cli.assetstore.yml run --rm dspace-cli
-          docker container ls
-
-      # Run integration tests via Cypress.io
-      # https://github.com/cypress-io/github-action
-      # (NOTE: to run these e2e tests locally, just use 'ng e2e')
-      - name: Run e2e tests (integration tests)
-        uses: cypress-io/github-action@v6
-        with:
-          # Run tests in Chrome, headless mode (default)
-          browser: chrome
-          # Start app before running tests (will be stopped automatically after tests finish)
-          start: yarn run serve:ssr
-          # Wait for backend & frontend to be available
-          # NOTE: We use the 'sites' REST endpoint to also ensure the database is ready
-          wait-on: http://127.0.0.1:8080/server/api/core/sites, http://127.0.0.1:4000
-          # Wait for 2 mins max for everything to respond
-          wait-on-timeout: 120
-
-      # Cypress always creates a video of all e2e tests (whether they succeeded or failed)
-      # Save those in an Artifact
-      - name: Upload e2e test videos to Artifacts
-        uses: actions/upload-artifact@v4
-        if: always()
-        with:
-          name: e2e-test-videos-${{ matrix.node-version }}
-          path: cypress/videos
-
-      # If e2e tests fail, Cypress creates a screenshot of what happened
-      # Save those in an Artifact
-      - name: Upload e2e test failure screenshots to Artifacts
-        uses: actions/upload-artifact@v4
-        if: failure()
-        with:
-          name: e2e-test-screenshots-${{ matrix.node-version }}
-          path: cypress/screenshots
-
-      - name: Stop app (in case it stays up after e2e tests)
-        run: |
-          app_pid=$(lsof -t -i:4000)
-          if [[ ! -z $app_pid ]]; then
-            echo "App was still up! (PID: $app_pid)"
-            kill -9 $app_pid
-          fi
-
-      # Start up the app with SSR enabled (run in background)
-      - name: Start app in SSR (server-side rendering) mode
-        run: |
-          nohup yarn run serve:ssr &
-          printf 'Waiting for app to start'
-          until curl --output /dev/null --silent --head --fail http://127.0.0.1:4000/home; do
-            printf '.'
-            sleep 2
-          done
-          echo "App started successfully."
-
-      # Get homepage and verify that the <meta name="title"> tag includes "DSpace".
-      # If it does, then SSR is working, as this tag is created by our MetadataService.
-      # This step also prints entire HTML of homepage for easier debugging if grep fails.
-      - name: Verify SSR (server-side rendering) on Homepage
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/home)
-          echo "$result"
-          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep DSpace
-
-      # Get a specific community in our test data and verify that the "<h1>" tag includes "Publications" (the community name).
-      # If it does, then SSR is working.
-      - name: Verify SSR on a Community page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/communities/0958c910-2037-42a9-81c7-dca80e3892b4)
-          echo "$result"
-          echo "$result" | grep -oE "<h1 [^>]*>[^><]*</h1>" | grep Publications
-
-      # Get a specific collection in our test data and verify that the "<h1>" tag includes "Articles" (the collection name).
-      # If it does, then SSR is working.
-      - name: Verify SSR on a Collection page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/collections/282164f5-d325-4740-8dd1-fa4d6d3e7200)
-          echo "$result"
-          echo "$result" | grep -oE "<h1 [^>]*>[^><]*</h1>" | grep Articles
-
-      # Get a specific publication in our test data and verify that the <meta name="title"> tag includes
-      # the title of this publication. If it does, then SSR is working.
-      - name: Verify SSR on a Publication page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/entities/publication/6160810f-1e53-40db-81ef-f6621a727398)
-          echo "$result"
-          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep "An Economic Model of Mortality Salience"
-
-      # Get a specific person in our test data and verify that the <meta name="title"> tag includes
-      # the name of the person. If it does, then SSR is working.
-      - name: Verify SSR on a Person page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/entities/person/b1b2c768-bda1-448a-a073-fc541e8b24d9)
-          echo "$result"
-          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep "Simmons, Cameron"
-
-      # Get a specific project in our test data and verify that the <meta name="title"> tag includes
-      # the name of the project. If it does, then SSR is working.
-      - name: Verify SSR on a Project page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/entities/project/46ccb608-a74c-4bf6-bc7a-e29cc7defea9)
-          echo "$result"
-          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep "University Research Fellowship"
-
-      # Get a specific orgunit in our test data and verify that the <meta name="title"> tag includes
-      # the name of the orgunit. If it does, then SSR is working.
-      - name: Verify SSR on an OrgUnit page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/entities/orgunit/9851674d-bd9a-467b-8d84-068deb568ccf)
-          echo "$result"
-          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep "Law and Development"
-
-      # Get a specific journal in our test data and verify that the <meta name="title"> tag includes
-      # the name of the journal. If it does, then SSR is working.
-      - name: Verify SSR on a Journal page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/entities/journal/d4af6c3e-53d0-4757-81eb-566f3b45d63a)
-          echo "$result"
-          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep "Environmental &amp; Architectural Phenomenology"
-
-      # Get a specific journal volume in our test data and verify that the <meta name="title"> tag includes
-      # the name of the volume. If it does, then SSR is working.
-      - name: Verify SSR on a Journal Volume page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/entities/journalvolume/07c6249f-4bf7-494d-9ce3-6ffdb2aed538)
-          echo "$result"
-          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep "Environmental &amp; Architectural Phenomenology Volume 28 (2017)"
-
-      # Get a specific journal issue in our test data and verify that the <meta name="title"> tag includes
-      # the name of the issue. If it does, then SSR is working.
-      - name: Verify SSR on a Journal Issue page
-        run: |
-          result=$(wget -O- -q http://127.0.0.1:4000/entities/journalissue/44c29473-5de2-48fa-b005-e5029aa1a50b)
-          echo "$result"
-          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep "Environmental &amp; Architectural Phenomenology Vol. 28, No. 1"
-
-      # Verify 301 Handle redirect behavior
-      # Note: /handle/123456789/260 is the same test Publication used by our e2e tests
-      - name: Verify 301 redirect from '/handle' URLs
-        run: |
-          result=$(wget --server-response --quiet http://127.0.0.1:4000/handle/123456789/260 2>&1 | head -1 | awk '{print $2}')
-          echo "$result"
-          [[ "$result" -eq "301" ]]
-
-      # Verify 403 error code behavior
-      - name: Verify 403 error code from '/403'
-        run: |
-          result=$(wget --server-response --quiet http://127.0.0.1:4000/403 2>&1 | head -1 | awk '{print $2}')
-          echo "$result"
-          [[ "$result" -eq "403" ]]
-
-      # Verify 404 error code behavior
-      - name: Verify 404 error code from '/404' and on invalid pages
-        run: |
-          result=$(wget --server-response --quiet http://127.0.0.1:4000/404 2>&1 | head -1 | awk '{print $2}')
-          echo "$result"
-          result2=$(wget --server-response --quiet http://127.0.0.1:4000/invalidurl 2>&1 | head -1 | awk '{print $2}')
-          echo "$result2"
-          [[ "$result" -eq "404" && "$result2" -eq "404" ]]
-
-      # Verify 500 error code behavior
-      - name: Verify 500 error code from '/500'
-        run: |
-          result=$(wget --server-response --quiet http://127.0.0.1:4000/500 2>&1 | head -1 | awk '{print $2}')
-          echo "$result"
-          [[ "$result" -eq "500" ]]
-
-      - name: Stop running app
-        run: kill -9 $(lsof -t -i:4000)
-
-      - name: Shutdown Docker containers
-        run: docker compose -f ./docker/docker-compose-ci.yml down
-
-  # Codecov upload is a separate job in order to allow us to restart this separate from the entire build/test
-  # job above. This is necessary because Codecov uploads seem to randomly fail at times.
-  # See https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954
-  codecov:
-    # Must run after 'tests' job above
-    needs: tests
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      # Download artifacts from previous 'tests' job
-      - name: Download coverage artifacts
-        uses: actions/download-artifact@v4
-
-      # Now attempt upload to Codecov using its action.
-      # NOTE: We use a retry action to retry the Codecov upload if it fails the first time.
-      #
-      # Retry action: https://github.com/marketplace/actions/retry-action
-      # Codecov action: https://github.com/codecov/codecov-action
-      - name: Upload coverage to Codecov.io
-        uses: Wandalen/wretry.action@v1.3.0
-        with:
-          action: codecov/codecov-action@v4
-          # Ensure codecov-action throws an error when it fails to upload
-          # This allows us to auto-restart the action if an error is thrown
-          with: |
-            fail_ci_if_error: true
-            token: ${{ secrets.CODECOV_TOKEN }}
-          # Try re-running action 5 times max
-          attempt_limit: 5
-          # Run again in 30 seconds
-          attempt_delay: 30000
+      # NOTE: e2e tests, SSR verification and Docker backend steps have been removed.
+      # This fork does not have a DSpace REST backend Docker image configured for CI.
diff --git a/.github/workflows/codescan.yml b/.github/workflows/codescan.yml
@@ -40,14 +40,14 @@ jobs:
       # Initializes the CodeQL tools for scanning.
       # https://github.com/github/codeql-action
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v2
+        uses: github/codeql-action/init@v3
         with:
           languages: javascript
 
       # Autobuild attempts to build any compiled languages
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v2
+        uses: github/codeql-action/autobuild@v3
 
       # Perform GitHub Code Scanning.
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v2
+        uses: github/codeql-action/analyze@v3
