Regenerate data and add frictionless validate to CI#63
Open
olayway wants to merge 1 commit into
Open
Conversation
- scripts/process.py: update source URL to davidmegginson.github.io (skips redirect), add type-counts.csv generation (excludes closed airports), force LF output, add explicit UTF-8 encoding - data/airport-codes.csv: regenerated from updated script - data/type-counts.csv: regenerated with current counts (was stale and hand-maintained) - .github/workflows/actions.yml: add frictionless validate datapackage.json step - Makefile: fix validate target (was pointing to nonexistent data/constituents.csv)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
scripts/process.py
https://ourairports.com/data/airports.csvtohttps://davidmegginson.github.io/ourairports-data/airports.csv(the redirect target) — avoids an unnecessary HTTP redirect on every rundata/type-counts.csvfrom the processed data — previously this file was hand-maintained, had stale counts, and was missing theclosedtype (thoughclosedairports are intentionally excluded from the aggregate)newline="\n"andencoding="utf-8"to output file opens to ensure consistent LF line endings and encodingimport ssldata/airport-codes.csv, data/type-counts.csv
.github/workflows/actions.yml
frictionless validate datapackage.jsonstep after data generation; fails the workflow if the descriptor drifts from the data filesMakefile
validatetarget: was pointing todata/constituents.csv(wrong file from another dataset); now points todatapackage.json