Skip to content

Commit 8bd45f9

Browse files
committed
Further issue fixes
1 parent 0db81a0 commit 8bd45f9

4 files changed

Lines changed: 47 additions & 16 deletions

File tree

DESCRIPTION

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ Imports:
7777
tidyselect
7878
Suggests:
7979
spelling,
80-
testthat
80+
testthat,
81+
tidytable
8182
RoxygenNote: 7.3.3
8283
Encoding: UTF-8
8384
Language: en-GB

azure-pipelines.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ jobs:
124124
sudo R -e "install.packages('purrr', dependencies=TRUE)"
125125
sudo R -e "install.packages('tibble', dependencies=TRUE)"
126126
sudo R -e "install.packages('tidyselect', dependencies=TRUE)"
127+
sudo R -e "install.packages('tidytable', dependencies=TRUE)"
127128
128129
displayName: 'Install all dependencies for dsBase'
129130
condition: succeeded()

tests/testthat/test-smk-asDataMatrixDS.R

Lines changed: 43 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#-------------------------------------------------------------------------------
22
# Copyright (c) 2019-2022 University of Newcastle upon Tyne. All rights reserved.
3+
# Copyright (c) 2026 Arjuna Technologies, Newcastle upon Tyne. All rights reserved.
34
#
45
# This program and the accompanying materials
56
# are made available under the terms of the GNU Public License v3.0.
@@ -29,25 +30,53 @@ test_that("simple asDataMatrixDS", {
2930
{
3031
expect_length(res.class, 1)
3132
expect_true("matrix" %in% res.class)
33+
34+
expect_length(res, 10)
35+
expect_equal(res[1], 0)
36+
expect_equal(res[2], 1)
37+
expect_equal(res[3], 2)
38+
expect_equal(res[4], 3)
39+
expect_equal(res[5], 4)
40+
expect_equal(res[6], 4)
41+
expect_equal(res[7], 3)
42+
expect_equal(res[8], 2)
43+
expect_equal(res[9], 1)
44+
expect_equal(res[10], 0)
3245
}
33-
else
46+
else if (base::getRversion() < '4.0.1')
3447
{
3548
expect_length(res.class, 2)
36-
expect_true("matrix" %in% res.class)
37-
expect_true("array" %in% res.class)
49+
expect_true(all(c("matrix", "array") %in% res.class))
50+
51+
expect_length(res, 10)
52+
expect_equal(res[1], 0)
53+
expect_equal(res[2], 1)
54+
expect_equal(res[3], 2)
55+
expect_equal(res[4], 3)
56+
expect_equal(res[5], 4)
57+
expect_equal(res[6], 4)
58+
expect_equal(res[7], 3)
59+
expect_equal(res[8], 2)
60+
expect_equal(res[9], 1)
61+
expect_equal(res[10], 0)
3862
}
63+
else
64+
{
65+
expect_length(res.class, 1)
66+
expect_true(all("data.frame" %in% res.class))
3967

40-
expect_length(res, 10)
41-
expect_equal(res[1], 0)
42-
expect_equal(res[2], 1)
43-
expect_equal(res[3], 2)
44-
expect_equal(res[4], 3)
45-
expect_equal(res[5], 4)
46-
expect_equal(res[6], 4)
47-
expect_equal(res[7], 3)
48-
expect_equal(res[8], 2)
49-
expect_equal(res[9], 1)
50-
expect_equal(res[10], 0)
68+
expect_length(res, 2)
69+
expect_equal(res[1, 1], 0)
70+
expect_equal(res[2, 1], 1)
71+
expect_equal(res[3, 1], 2)
72+
expect_equal(res[4, 1], 3)
73+
expect_equal(res[5, 1], 4)
74+
expect_equal(res[1, 2], 4)
75+
expect_equal(res[2, 2], 3)
76+
expect_equal(res[3, 2], 2)
77+
expect_equal(res[4, 2], 1)
78+
expect_equal(res[5, 2], 0)
79+
}
5180

5281
res.colnames <- colnames(res)
5382
expect_length(res.colnames, 2)

tests/testthat/test-smk-standardiseDfDS.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ test_that("fixClassDS sets classes correctly", {
4949
)
5050

5151
expect_equal(
52-
classes_changed_df %>% map_chr(class) %>% unname(),
52+
classes_changed_df %>% tidytable::map_chr(class) %>% unname(),
5353
c("factor", "factor", "numeric", "factor", "factor", "factor", "factor", "integer", "factor",
5454
"factor", "factor", "factor", "character", "logical", "factor", "integer", "integer",
5555
"numeric", "logical", "integer", "character", "numeric", "numeric", "character", "numeric",

0 commit comments

Comments
 (0)