Skip to content

Commit c5e961e

Browse files
committed
added template with checklist for PRs
1 parent 6771731 commit c5e961e

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

pull_request_template

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
## Description
2+
[Write a description of the changes you have made]
3+
4+
## Checklist (all items may not apply)
5+
6+
### Refactor
7+
- [ ] Replace `eval(parse(text = x), envir = parent.frame())` with `.loadServersideObject()`
8+
- [ ] Where appropriate, check object class using `.checkClass()
9+
- [ ] Check whether additional checks are required on the server-side
10+
11+
### Testing
12+
- [ ] Writen server-side unit tests for unhappy flow
13+
- [ ] Run and passed `devtools::test(filter = "smk-|disc|arg")`
14+
- [ ] Run and passed `devtools::check(args = '--no-tests')` (we run tests separately to skip performance checks)
15+
- [ ] Run and passed `devtools::build`

0 commit comments

Comments
 (0)