feat: Support for passing certificate path in httpx calls#409
Merged
Conversation
- assert the async client shares the same custom SSL context as the sync client - add an explicit-None override case (resets to the certifi default) - correct a misleading comment (omitted/UNSET field vs explicit None) - add a CHANGES entry for the new ca_cert_path option
sl-at-ibm
approved these changes
Jun 15, 2026
sl-at-ibm
force-pushed
the
feat-verify-certs
branch
from
cf65025 to
756391b
Compare
Coverage reportfor commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for specifying a custom CA certificate path for SSL verification when connecting to the API. This is useful for environments with custom certificate requirements, such as PrivateLink setups. The change propagates the new
ca_cert_pathoption throughout the codebase, ensures it is properly inherited and handled in configuration objects, and adds unit tests to verify correct behavior.New SSL certificate configuration support:
ca_cert_pathoption toAPIOptionsandFullAPIOptions, including initialization, representation, inheritance, and default value handling. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]APICommanderto accept and use a custom SSL context based onca_cert_path, ensuring the correct SSL context is used for both sync and async clients, and that it is preserved during object copying. [1] [2]Propagation of CA certificate option in API commander creation:
ca_cert_pathfromAPIOptionsto all relevantAPICommanderinstantiations inastrapy/admin/admin.py,astrapy/data/collection.py,astrapy/data/database.py, andastrapy/data/table.py. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Testing enhancements:
APICommanderto verify correct SSL context creation and inheritance withca_cert_path, including preservation during copying.APIOptionsto verify correct inheritance and override behavior ofca_cert_path.