Minor cursor behaviour improvements (+ testing)#428
Merged
Conversation
…rsor behaviour improve cursor testing for rewound formerly-closed cursors refine type-ignore hints across cursor tests
…nt w/ other clients)
…t w/ other clients)
erichare
reviewed
Jun 25, 2026
Collaborator
There was a problem hiding this comment.
Should this comment be updated now that STARTED is set?
Collaborator
Author
There was a problem hiding this comment.
Ah. That's correct. Thanks for spotting this!
Fixed. (6 separate docstrings).
erichare
approved these changes
Jun 25, 2026
erichare
left a comment
erichare
left a comment
Collaborator
There was a problem hiding this comment.
LGTM @sl-at-ibm, one NIT comment
Coverage reportfor commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes/enhances a couple of details in the cursor testing and introduces two slight changes in the cursor behaviour, related to reflecting more faithfully the cursor state (IDLE -> STARTED -> CLOSED) under certain operations.
(it also denylists some unreleased vectorize models to be able to run vectorize tests on certain dev deployments, but this is irrelevant)
The cursor behaviour changes, dictated by a better alignment with the Typescript client cursor behaviour, are so tiny that I do not think they should be treated as "breaking changes", rather as essentially bug fixes. "started" means we started issuing request, and "closed" means there is nothing more to fetch, so...