AS-5309: CVE fixes from security team for admin console#121
Open
hshankar31 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security: Resolve 6 Critical CVEs in Dependencies
Summary
This PR addresses 8 CVEs identified by the security team, successfully resolving 6 of them through dependency updates. Two CVEs (CVE-2025-59436, CVE-2025-59437) require breaking changes and are documented for future resolution.
CVEs Resolved ✅
High Severity
Critical Severity (Requires Breaking Changes)⚠️
Note: The
ippackage CVEs are blocked by webpack-dev-server 3.x dependency. Resolution requires upgrading to Vue CLI 5+ and webpack-dev-server 4.x/5.x, which involves breaking changes.Changes Made
Dashboard (
dashboard/)axiosfrom ^0.21.1 to ^1.8.0semverfrom ^5.7.0 to ^5.7.2tar@^6.2.1shell-quote@^1.8.2glob-parent@^5.1.2ws@^8.18.0underscore@^1.13.8postcss@^8.4.49node-forge@^1.3.1flatted@^3.3.2ajv@^6.14.0uuid@^11.1.1ip@^2.0.1(attempted, blocked by webpack-dev-server)brace-expansion@^1.1.13minimatch@^3.1.3Server (
server/)axiosfrom ^1.15.2 to ^1.16.0http-proxy-middlewarefrom ^2.0.1 to ^3.0.7nodemonfrom ^2.0.15 to ^3.0.0minimatch@^3.1.5as devDependencyajv@^6.14.0brace-expansion@^2.0.3form-data@^4.0.6lodash@^4.17.24minimatch@^3.1.5picomatch@^2.3.2qs@^6.15.2underscore@^1.13.8path-to-regexp@^0.1.13tough-cookie@^4.1.3uuid@^11.1.1ws@^8.18.0follow-redirects@^1.15.12axios@^1.16.0Testing
Dashboard
npm installcompleted successfullynpm run buildcompleted successfully (with expected Sass deprecation warnings)npm auditServer
npm installcompleted successfullynpm testpassed (2/2 tests)npm auditVerification Commands
Both commands return empty results, confirming all resolvable CVEs are fixed.
Impact Assessment
Security Impact
Compatibility Impact
Performance Impact
Remaining Work
Future PRs Required
Other Vulnerabilities
Both directories still have vulnerabilities from packages not in the requested CVE list:
ip)jsonpath-plus)These should be addressed in separate PRs to maintain focused changes.
Additional Notes
Dependency Management Strategy
resolutions(dashboard) andoverrides(server) to force transitive dependency updatesReview Checklist
npm auditReferences
CVE_REMEDIATION_SUMMARY.mdDeployment Notes
Pre-deployment
Post-deployment
Resolves: AS-5309 (partial - 6 of 8 CVEs)
Related Issues: Future PR needed for CVE-2025-59436, CVE-2025-59437