Add nmrglue extractor - #33
Merged
Merged
Conversation
ml-evs
marked this pull request as ready for review
June 17, 2025 09:55
PeterKraus
approved these changes
Jun 17, 2025
Comment on lines
+10
to
+16
| supported_filetypes: | ||
| - id: jcamp-dx | ||
| template: | ||
| input_type: jcampdx | ||
| description: >- | ||
| Note: Only 1D NMR data is supported, not the full JCAMP-DX standard. Many | ||
| other NMR data file formats are supported. |
Comment on lines
+36
to
+38
| - method: python | ||
| setup: nmrglue | ||
| command: nmrglue.fileio.{{ input_type }}.read |
Contributor
There was a problem hiding this comment.
Is yadg the only package that bothered with a command-line API?
Member
Author
There was a problem hiding this comment.
Imagine so, presumably because you embed some provenance and traceability in your output format, where most other codes don't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an extractor for https://github.com/jjhelmus/nmrglue.