fix: remove unnecessary MemTable cloning

Author: michaelmior

src/db.rs

@@ -248,7 +248,8 @@ impl Collection {
 
     fn flush(&mut self) {
         let jstable_path = self.dir.join(format!("jstable-{}", self.jstable_count));
-        self.memtable
+        let memtable = std::mem::take(&mut self.memtable);
+        memtable
             .flush(
                 jstable_path.to_str().unwrap(),
                 self.name.clone(),
@@ -264,7 +265,6 @@ impl Collection {
         self.tables.push(LoadedTable { filter, index });
 
         self.jstable_count += 1;
-        self.memtable = MemTable::new();
         self.logger.rotate().unwrap();
 
         if self.jstable_count >= self.jstable_threshold {

src/storage.rs

@@ -31,7 +31,7 @@ impl MemTable {
     }
 
     pub fn flush(
-        &self,
+        self,
         path: &str,
         collection: String,
         index_threshold: u64,
@@ -40,12 +40,7 @@ impl MemTable {
             .duration_since(std::time::UNIX_EPOCH)
             .unwrap()
             .as_millis() as u64;
-        let jstable = JSTable::new(
-            timestamp,
-            collection,
-            self.schema.clone(),
-            self.documents.clone(),
-        );
+        let jstable = JSTable::new(timestamp, collection, self.schema, self.documents);
         jstable.write(path, index_threshold)
     }