Merge pull request #94 from JesusTheHun/fix-getEdgeProperties

curran · web-flow · commit 3f8fb2cb6c3c · 2024-10-23T11:32:10.000-04:00
fix: `getEdgeProperties` may return `undefined` if the edge doesn't exists
diff --git a/src/Graph.ts b/src/Graph.ts
@@ -106,10 +106,10 @@ export class Graph<Node = string, LinkProps = never> {
   }
 
   /**
-   * Get the properties of the given edge or undefined if none are set.
+   * Get the properties of the given edge or undefined if the edge doesn't exist .
    */
-  getEdgeProperties(source: Node, target: Node): LinkProps {
-    return this.edgeProperties.get(source)?.get(target) as LinkProps;
+  getEdgeProperties(source: Node, target: Node): LinkProps | undefined {
+    return this.edgeProperties.get(source)?.get(target);
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -106,10 +106,10 @@ export class Graph<Node = string, LinkProps = never> {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`/**`
`109`		`- * Get the properties of the given edge or undefined if none are set.`
	`109`	`+ * Get the properties of the given edge or undefined if the edge doesn't exist .`
`110`	`110`	`*/`
`111`		`- getEdgeProperties(source: Node, target: Node): LinkProps {`
`112`		`- return this.edgeProperties.get(source)?.get(target) as LinkProps;`
	`111`	`+ getEdgeProperties(source: Node, target: Node): LinkProps \| undefined {`
	`112`	`+ return this.edgeProperties.get(source)?.get(target);`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`/**`