chore: refactor unit test table construction

Author: KevinVandy

examples/react/kitchen-sink/src/routes/__root.tsx

@@ -45,7 +45,10 @@ export const Route = createRootRoute({
       { title: 'TanStack Table Kitchen Sink (Start SSR)' },
     ],
     links: [{ rel: 'stylesheet', href: appCss }],
-    scripts: [{ children: consoleProbe }],
+    scripts: [
+      { src: 'https://unpkg.com/react-scan/dist/auto.global.js' },
+      { children: consoleProbe },
+    ],
   }),
   component: RootComponent,
 })

examples/react/web-worker-row-models/src/routes/__root.tsx

@@ -45,7 +45,10 @@ export const Route = createRootRoute({
       { title: 'TanStack Table Web Worker Row Models (Start SSR)' },
     ],
     links: [{ rel: 'stylesheet', href: appCss }],
-    scripts: [{ children: consoleProbe }],
+    scripts: [
+      { src: 'https://unpkg.com/react-scan/dist/auto.global.js' },
+      { children: consoleProbe },
+    ],
   }),
   component: RootComponent,
 })

packages/table-core/src/core/table/coreTablesFeature.types.ts

@@ -74,13 +74,13 @@ export type ExternalAtoms<TFeatures extends TableFeatures> = Partial<{
  * use optional chaining (`table.atoms.columnPinning?.get() ?? default`).
  */
 export type BaseAtoms_All = {
-  [K in keyof TableState_All]?: Atom<TableState_All[K]>
+  [K in keyof TableState_All]?: Atom<Exclude<TableState_All[K], undefined>>
 }
 export type Atoms_All = {
   [K in keyof TableState_All]?: ReadonlyAtom<TableState_All[K]>
 }
 export type ExternalAtoms_All = Partial<{
-  [K in keyof TableState_All]: Atom<TableState_All[K]>
+  [K in keyof TableState_All]: Atom<Exclude<TableState_All[K], undefined>>
 }>
 
 export interface TableOptions_Table<

packages/table-core/src/types/RowModel.ts

@@ -1,10 +1,7 @@
 import type { CachedRowModel_Faceted } from '../features/column-faceting/columnFacetingFeature.types'
 import type { CachedRowModel_Grouped } from '../features/column-grouping/columnGroupingFeature.types'
 import type { CachedRowModel_Filtered } from '../features/column-filtering/columnFilteringFeature.types'
-import type {
-  CachedRowModel_Core,
-  RowModel,
-} from '../core/row-models/coreRowModelsFeature.types'
+import type { CachedRowModel_Core } from '../core/row-models/coreRowModelsFeature.types'
 import type { CachedRowModel_Expanded } from '../features/row-expanding/rowExpandingFeature.types'
 import type { CachedRowModel_Paginated } from '../features/row-pagination/rowPaginationFeature.types'
 import type { CachedRowModel_Sorted } from '../features/row-sorting/rowSortingFeature.types'
@@ -26,12 +23,11 @@ export interface CachedRowModels_FeatureMap<
 export type CachedRowModels<
   TFeatures extends TableFeatures,
   TData extends RowData,
-> = {
-  CachedRowModel_Core: () => RowModel<TFeatures, TData>
-} & ExtractFeatureMapTypes<
-  TFeatures,
-  CachedRowModels_FeatureMap<TFeatures, TData>
->
+> = Partial<CachedRowModel_Core<TFeatures, TData>> &
+  ExtractFeatureMapTypes<
+    TFeatures,
+    CachedRowModels_FeatureMap<TFeatures, TData>
+  >
 
 export interface CachedRowModel_All<
   in out TFeatures extends TableFeatures,

packages/table-core/src/worker/initTableWorker.ts

@@ -79,7 +79,7 @@ export function initTableWorker<
             ...config.features,
           },
           data: message.data,
-        }) as unknown as Table_Internal<TFeatures, TData>
+        })
         // Only columns with an explicit aggregation get eagerly aggregated
         // per group. Sync tables aggregate lazily (visible cells only), so
         // auto-aggregating every column would explode on high-cardinality

packages/table-core/src/worker/rebuildRowModel.ts

@@ -2,6 +2,8 @@ import { constructRow } from '../core/rows/constructRow'
 import { hasOwn } from '../utils'
 import type { RowModel } from '../core/row-models/coreRowModelsFeature.types'
 import type { Table_Internal } from '../types/Table'
+import type { TableFeatures } from '../types/TableFeatures'
+import type { RowData } from '../types/type-utils'
 import type {
   TableWorkerRowNode,
   TableWorkerStagePayload,
@@ -13,8 +15,6 @@ export type TableWorkerDataPayload = Exclude<
   { kind: 'unchanged' }
 >
 
-type AnyTable = Table_Internal<any, any>
-
 // Main-thread side: payload + this table's core rows -> RowModel. Mirrors how
 // the sync row models treat rows: data rows are reused (with depth/parentId
 // rewritten, exactly like createGroupedRowModel does), synthetic group rows
@@ -32,8 +32,11 @@ function collectLeafRows(subRows: Array<any>, out: Array<any>) {
   }
 }
 
-export function rebuildRowModel(
-  table: AnyTable,
+export function rebuildRowModel<
+  TFeatures extends TableFeatures,
+  TData extends RowData,
+>(
+  table: Table_Internal<TFeatures, TData>,
   payload: TableWorkerDataPayload,
   /**
    * Whether a flat payload should rewrite row depth/parentId. Mirrors core:
@@ -42,7 +45,7 @@ export function rebuildRowModel(
    * depths a grouped/sorted tree rebuild just assigned to shared row objects.
    */
   resetDepths: boolean,
-): RowModel<any, any> {
+): RowModel<TFeatures, TData> {
   const core = table.getCoreRowModel()
 
   if (payload.kind === 'flat') {

packages/table-core/tests/fixtures/features.ts

@@ -0,0 +1,22 @@
+import { coreFeatures } from '../../src'
+import { storeReactivityBindings } from '../../src/store-reactivity-bindings'
+import type {
+  CoreFeatures,
+  TableFeatures,
+  ValidateFeatureSlots,
+} from '../../src'
+
+/**
+ * `tableFeatures` for tests: injects the core features plus the store
+ * reactivity bindings that `constructTable` requires, so each test file only
+ * declares the features, row model factories, and fn registries it tests.
+ */
+export function testFeatures<TFeatures extends TableFeatures>(
+  features: TFeatures & ValidateFeatureSlots<TFeatures>,
+): CoreFeatures & TFeatures {
+  return {
+    ...coreFeatures,
+    coreReactivityFeature: storeReactivityBindings(),
+    ...features,
+  }
+}