feat: rolling writer in s3 destination#1012
Open
mihir-datazip wants to merge 2 commits into
Open
Conversation
chore: release olake version v0.7.8
2e6f01b to
ced2436
Compare
ced2436 to
3275ba1
Compare
3275ba1 to
110fd79
Compare
110fd79 to
3181153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is regarding https://datazip.atlassian.net/browse/OL-2905
The parquet destination previously buffered an entire partition in the writer's memory and uploaded one file per partition at the end of the sync. Memory grew linearly with partition size and produced a single oversized object. This branch streams each partition to a local file and rolls it into multiple size-bounded files, uploading each as it's sealed.
Fixes # (issue)
Type of change
How Has This Been Tested?
Following are the benchmark results (with mocked upload latency)
Old Writer
New Writer
Screenshots or Recordings
Old writer(without rolling) -> 2GB single parquet

New Writer(with 512 MB rolling) -> 4 files with ~512MB size per file

Documentation
Related PR's (If Any):
datazip-inc/olake-docs#450