Skip to content

Change binlog check from metadata to image #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vladislaff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change binlog check from metadata to image #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/mysql/internal/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ func (m *MySQL) IsCDCSupported(ctx context.Context) (bool, error) {
}{
{jdbc.MySQLLogBinQuery(), "ON", "log_bin is not enabled"},
{jdbc.MySQLBinlogFormatQuery(), "ROW", "binlog_format is not set to ROW"},
{jdbc.MySQLBinlogRowMetadataQuery(), "FULL", "binlog_row_metadata is not set to FULL"},
{jdbc.MySQLBinlogRowImageQuery(), "FULL", "binlog_row_image is not set to FULL"},
}

for _, check := range configChecks {
Expand Down
5 changes: 5 additions & 0 deletions pkg/jdbc/jdbc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,11 @@ func MySQLBinlogRowMetadataQuery() string {
return "SHOW VARIABLES LIKE 'binlog_row_metadata'"
}

// MySQLBinlogRowImageQuery returns the query to fetch the binlog_row_image variable in MySQL
func MySQLBinlogRowImageQuery() string {
return "SHOW VARIABLES LIKE 'binlog_row_image'"
}

// MySQLTableColumnsQuery returns the query to fetch column names of a table in MySQL
func MySQLTableColumnsQuery() string {
return `
Expand Down