fix: evitar KeyError por altura ausente en /ubicacion (#240)#241
Open
matzalazar wants to merge 1 commit into
Open
fix: evitar KeyError por altura ausente en /ubicacion (#240)#241matzalazar wants to merge 1 commit into
matzalazar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción:
Este PR resuelve un error crítico (HTTP 500) que ocurría al realizar consultas al recurso /ubicacion
con coordenadas que no resultaban en una altura de calle válida.
Cambios principales:
KeyError: Se reemplazó el acceso directo por índicesb['altura']por el método segurosb.get('altura')en la función_address_full_namedeservice/location.py.door_numbersea un string vacío, evitando la aparición del literal "None" en la nomenclatura final de la dirección.requirements-dev.txtpara incluir las dependencias de producción (-r requirements.txt), facilitando la ejecución de tests y configuración de entornos locales.Investigación técnica:
Durante el diagnóstico, se identificó que el bug afectaba a la rama development (que es la versión
que actualmente corre en el entorno de producción de la API pública), mientras que la rama master del
repositorio aún no integraba esta funcionalidad de geocodificación inversa detallada.