Updates to get the example in the README.md working#2
Open
cowlicks wants to merge 11 commits intodatrs:masterfrom
Open
Updates to get the example in the README.md working#2cowlicks wants to merge 11 commits intodatrs:masterfrom
cowlicks wants to merge 11 commits intodatrs:masterfrom
Conversation
This dir does not exist so `cargo` would fail on every command.
The usage within the library was not compatible with the version listed in Cargo.toml. So I updated, and reworked the code to the current Clap
I'm new to codebase so I don't feel comfortable removing these yet
Please enter the commit message for your changes. Lines starting
ttiurani
approved these changes
Apr 7, 2024
Member
ttiurani
left a comment
ttiurani
left a comment
There was a problem hiding this comment.
Looks reasonable, good to have the example to at least work before doing anything else. Is the idea to upgrade hypercore-protocol to latest master eventually?
Member
Author
|
@ttiurani That is the plan! I'd like to use some of the functionality in here (in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were needed to get the example in the
README.mdworking, and to silence existing warnings. There was only one existing test, and it passes.The only thing that may be controversial here are these two places where I've patched dependencies, and point to my own fork. This is intended to be a temporary solution. The practice is common within this repo. User @Frando own several of these branches, but he is a more well known community member 😉.
libutp-syswhich I made to fix a build failure inbindgen.hypercore-protocol-rs v3.1However building this version is now broken because of it's dependency onsnow v0.7.0-alpha5which causes a build failure. The branch this now points to contains this patch which bumps the snow version to one that works (0.8). I would like to merge this upstream but thehypercore-protocol-rsrepository does not have a3.1tag or branch which I could make a PR against. A different fix could be bumping thehypercore-protocol-rsversion itself. I'm looking into this.