Skip to content

Commit 2ea89be

Browse files
ci(windows): pin to windows-2022 to dodge VS18 cmake/aws-lc-sys breakage
windows-latest currently aliases to the windows-2025 image, which ships Visual Studio 2026 preview (VS18 / MSVC 14.50). cmake-rs (used by aws-lc-sys, pulled in transitively via rustls -> aws-lc-rs) can't resolve a generator for VS18, and MSVC 14.50's vcruntime_c11_stdatomic.h demands /std:c11 which the aws-lc-sys build script doesn't pass. The result is a deterministic failure at `dx bundle` on windows-latest. Pin all three workflows to windows-2022 (VS17) until the toolchain catches up. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 06894ec commit 2ea89be

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

.github/workflows/bundle.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ jobs:
2525
fail-fast: false
2626
matrix:
2727
# PRs run linux only as a smoke check; main/tag/manual runs cover all three OSes.
28-
os: ${{ fromJSON(github.event_name == 'pull_request' && '["ubuntu-latest"]' || '["macos-latest","ubuntu-latest","windows-latest"]') }}
28+
# windows-2022 (not windows-latest): windows-latest aliases to VS18 preview,
29+
# whose MSVC 14.50 headers + cmake-rs can't resolve a Visual Studio generator
30+
# for aws-lc-sys, breaking `dx bundle`. Revisit once the ecosystem catches up.
31+
os: ${{ fromJSON(github.event_name == 'pull_request' && '["ubuntu-latest"]' || '["macos-latest","ubuntu-latest","windows-2022"]') }}
2932

3033
env:
3134
BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }}

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
os: [macos-latest, ubuntu-latest, windows-latest]
15+
# windows-2022 (not windows-latest) — see bundle.yml: windows-latest's VS18
16+
# preview breaks the aws-lc-sys cmake build via rustls.
17+
os: [macos-latest, ubuntu-latest, windows-2022]
1618

1719
steps:
1820
- uses: actions/checkout@v4

.github/workflows/manual-release.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22-
os: [macos-latest, ubuntu-latest, windows-latest]
22+
# windows-2022 (not windows-latest) — see bundle.yml: windows-latest's VS18
23+
# preview breaks the aws-lc-sys cmake build via rustls.
24+
os: [macos-latest, ubuntu-latest, windows-2022]
2325

2426
env:
2527
BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }}

0 commit comments

Comments
 (0)