Skip to content

Commit 86dc324

Browse files
zachsmith1claude
andcommitted
fix: wire BUILD_IROH_SERVICES_API_KEY into bundle and release workflows
The diagnostics module reads BUILD_IROH_SERVICES_API_KEY via option_env!() at compile time as a fallback when the runtime IROH_SERVICES_API_KEY isn't set, but neither workflow exported the secret to the build env, so released apps shipped without a key baked in and logged "Net diagnostics disabled: IROH_SERVICES_API_KEY not set" on launch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 9a3196b commit 86dc324

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/bundle.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919

2020
env:
2121
BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }}
22+
BUILD_IROH_SERVICES_API_KEY: ${{ secrets.BUILD_IROH_SERVICES_API_KEY }}
2223
BUILD_DATUM_CONNECT_RELAY_URLS: ${{ vars.BUILD_DATUM_CONNECT_RELAY_URLS }}
2324
BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES: ${{ vars.BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES }}
2425
DATUM_API_ENV: production

.github/workflows/manual-release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ jobs:
2323

2424
env:
2525
BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }}
26+
BUILD_IROH_SERVICES_API_KEY: ${{ secrets.BUILD_IROH_SERVICES_API_KEY }}
2627
BUILD_DATUM_CONNECT_RELAY_URLS: ${{ vars.BUILD_DATUM_CONNECT_RELAY_URLS }}
2728
BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES: ${{ vars.BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES }}
2829
DATUM_API_ENV: production

0 commit comments

Comments
 (0)