fix(e2e): match typeless org cards in Cypress selectors

[yahyafakhroji]

Problem

E2E Smoke has been failing intermittently across PRs (e.g. run on #1338):

Service Account new page › renders the create UI (not RestrictedState) for a permitted user
  AssertionError: Timed out retrying after 10000ms:
  Expected to find element: `[data-e2e="organization-card-personal"]`, but never found it.
  at cypress/support/e2e.ts   ← the shared getPersonalOrgId command

The failing assertion is in the shared getPersonalOrgId command — the cascade root that nearly every smoke/regression spec depends on — so a single missing hook fails the whole suite.

Root cause

The onboarding "unified org" work made organizations typeless. organization.adapter.ts now returns an undefined type for them:

/** Legacy org types only — unified orgs omit type or send empty values. */
function normalizeOrganizationType(type: unknown): Organization['type'] | undefined {
  return type === 'Personal' || type === 'Standard' ? type : undefined;
}

…and the org card derives its hook from that type:

data-e2e={ org.type ? `organization-card-${org.type.toLowerCase()}` : 'organization-card' }

So a typeless org renders data-e2e="organization-card", never -personal. The tests still waited on organization-card-personal and timed out.

Fix

This completes a migration the team already started — cypress/e2e/regression/organisations.cy.ts and cypress/support/e2e.ts:737 already use the [data-e2e^="organization-card"] prefix selector (as documented in the regression spec's selector reference). It was just missed in these spots:

• getPersonalOrgId + smoke render test → identify the personal org by its stable personal-org-… resource name (cy.contains on the id badge), independent of the removed type. This is the suite's own invariant (/^personal-org-[a-z0-9]+$/).
• createStandardOrg + auth regression → wait for any card variant via [data-e2e^="organization-card"].

No app code or dependency changes — test-only.

Scope & validation

• Local: prettier ✓, eslint ✓, typecheck ✓ (pre-commit gate green).
• These specs run against the live staging backend with CI secrets, so they can't be executed locally — CI on this PR is the real validation. Since the failure was intermittent (the type appears to populate asynchronously in staging), keying off the resource name rather than the type also removes that flake source.
• Unrelated to the Renovate batch in chore(deps): batch update dependencies to latest #1338 — this pre-existing E2E drift affects main and all open PRs.

[github-actions]

🧪 Test Summary

Job	Status
Bun Unit Tests	✅ success
E2E Regression (0)	⏭️ pending
E2E Regression (1)	⏭️ pending
E2E Regression (2)	⏭️ pending
E2E Regression (3)	⏭️ pending
E2E Smoke	✅ success
Unit Tests	✅ success

View workflow run

📎 Artifacts

Videos and screenshots from failed E2E tests:

• build-7f8ed7b8a924a3e0a1da7b9a5de5270abe8065d2 – Download
• bun-coverage-29064648174 – Download

[mattdjenkinson]

Thanks @yahyafakhroji!