Skip to content

Commit 46b88df

Browse files
scotwellsclaude
andcommitted
refactor(referenceddata): drop unused delivery types
SubjectRef, DeliveryRequest, and DeliveryResult had no consumers — speculative scaffolding in a package meant to be shared platform-wide. Remove them before they ship as API surface no one calls. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 88fc33d commit 46b88df

1 file changed

Lines changed: 0 additions & 34 deletions

File tree

internal/referenceddata/types.go

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -42,40 +42,6 @@ type ObjectRef struct {
4242
// collected from a workload template.
4343
type ReferencedSet []ObjectRef
4444

45-
// SubjectRef identifies the end-user making the admission request. Used by the
46-
// SAR admission check to verify that the submitting user can read each
47-
// referenced object.
48-
type SubjectRef struct {
49-
Username string
50-
Groups []string
51-
UID string
52-
}
53-
54-
// DeliveryRequest carries everything the resolver needs to materialise companion
55-
// objects on the downstream (cell) namespace.
56-
type DeliveryRequest struct {
57-
// Subject is the user identity used for admission authorisation.
58-
Subject SubjectRef
59-
60-
// ReferencedObjects is the deduplicated set of ConfigMaps and Secrets to deliver.
61-
ReferencedObjects ReferencedSet
62-
63-
// DownstreamNamespace is the namespace on the cell where companions will land
64-
// (typically ns-{project-uid}).
65-
DownstreamNamespace string
66-
}
67-
68-
// DeliveryResult is returned by the resolver after materialising companions.
69-
type DeliveryResult struct {
70-
// CompanionNames is the deterministic list of companion object names produced
71-
// by CompanionName, sorted the same way as the expected-set annotation.
72-
CompanionNames []string
73-
74-
// AllDelivered is true when every companion in CompanionNames was
75-
// successfully written (created or updated) to the downstream.
76-
AllDelivered bool
77-
}
78-
7945
// ProjectConfigSecretReader reads ConfigMaps and Secrets from a project's
8046
// control plane. Implementations must classify errors as ErrSourceNotFound or
8147
// ErrSourceUnauthorized where appropriate.

0 commit comments

Comments
 (0)