fix(lint): dedupe test fixture constants for goconst

Extract shared WorkloadDeployment test fixtures (cityCode, wdControllerTestUID)
and the quota-denied message into package-level constants so goconst no longer
flags repeated string literals across the controller test files.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: scotwells

internal/controller/instance_controller_test.go

@@ -46,6 +46,9 @@ const (
 	testQuotaAPIGroup          = "quota.miloapis.com"
 	testQuotaResource          = "resourceclaims"
 	kindWorkloadDeploymentTest = "WorkloadDeployment" // mirrors kindWorkloadDeployment
+
+	// testMsgQuotaExceeded is the quota-denied message used across quota tests.
+	testMsgQuotaExceeded = "Quota exceeded for project"
 )
 
 // newTestScheme builds a runtime.Scheme with the types needed for instance reconcile tests.
@@ -345,7 +348,7 @@ func TestReconcileInstanceReadyConditionWithQuota(t *testing.T) {
 							Type:               computev1alpha.InstanceQuotaGranted,
 							Status:             metav1.ConditionFalse,
 							Reason:             computev1alpha.InstanceQuotaGrantedReasonQuotaExceeded,
-							Message:            "Quota exceeded for project",
+							Message:            testMsgQuotaExceeded,
 							LastTransitionTime: metav1.Now(),
 						},
 						{
@@ -370,7 +373,7 @@ func TestReconcileInstanceReadyConditionWithQuota(t *testing.T) {
 				Type:    computev1alpha.InstanceReady,
 				Status:  metav1.ConditionFalse,
 				Reason:  computev1alpha.InstanceProgrammedReasonPendingQuota,
-				Message: "Quota exceeded for project",
+				Message: testMsgQuotaExceeded,
 			},
 		},
 		{

internal/controller/instance_referenced_data_test.go

@@ -751,7 +751,7 @@ func TestFederated_QuotaAndSourceNotFound_SourceNotFoundWins(t *testing.T) {
 			Type:               computev1alpha.InstanceQuotaGranted,
 			Status:             metav1.ConditionFalse,
 			Reason:             computev1alpha.InstanceQuotaGrantedReasonQuotaExceeded,
-			Message:            "Quota exceeded for project",
+			Message:            testMsgQuotaExceeded,
 			ObservedGeneration: 1,
 			LastTransitionTime: metav1.Now(),
 		},

internal/controller/workloaddeployment_location_test.go

@@ -34,7 +34,6 @@ func newNetworkingScheme() *runtime.Scheme {
 func TestReconcileNetworks_PersistsLocation_WhenLocationFound(t *testing.T) {
 	t.Parallel()
 
-	const cityCode = "DFW"
 	const locationName = "loc-dfw-1"
 	const locationNamespace = "networking-system"
 
@@ -45,7 +44,7 @@ func TestReconcileNetworks_PersistsLocation_WhenLocationFound(t *testing.T) {
 		},
 		Spec: networkingv1alpha.LocationSpec{
 			Topology: map[string]string{
-				"topology.datum.net/city-code": cityCode,
+				"topology.datum.net/city-code": wdControllerTestCityCode,
 			},
 		},
 	}
@@ -54,9 +53,9 @@ func TestReconcileNetworks_PersistsLocation_WhenLocationFound(t *testing.T) {
 	cl := fake.NewClientBuilder().WithScheme(s).WithObjects(location).Build()
 
 	deployment := &computev1alpha.WorkloadDeployment{
-		ObjectMeta: metav1.ObjectMeta{Name: "test-wd", Namespace: "default"},
+		ObjectMeta: metav1.ObjectMeta{Name: wdControllerTestName, Namespace: wdControllerTestNS},
 		Spec: computev1alpha.WorkloadDeploymentSpec{
-			CityCode: cityCode,
+			CityCode: wdControllerTestCityCode,
 			// No NetworkInterfaces — the function returns false,locationRef,nil
 			// after the location is found but before bindings are checked.
 		},
@@ -98,9 +97,9 @@ func TestReconcileNetworks_ReturnsNilLocation_WhenNoLocationFound(t *testing.T)
 	cl := fake.NewClientBuilder().WithScheme(s).WithObjects(otherLocation).Build()
 
 	deployment := &computev1alpha.WorkloadDeployment{
-		ObjectMeta: metav1.ObjectMeta{Name: "test-wd", Namespace: "default"},
+		ObjectMeta: metav1.ObjectMeta{Name: wdControllerTestName, Namespace: wdControllerTestNS},
 		Spec: computev1alpha.WorkloadDeploymentSpec{
-			CityCode: "DFW", // no matching Location
+			CityCode: wdControllerTestCityCode, // no matching Location
 		},
 	}