refactor(controller): centralize the companion ResourceBinding name codec

The "-configmap"/"-secret" suffix that maps a companion object to its Karmada
ResourceBinding name was open-coded across the GC, orphan-sweep, and resolver
paths. Add companionRBName as the inverse of companionFromRBName and share the
suffix constants so the build and parse sides cannot drift.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: scotwells

internal/controller/companion_gc_controller.go

@@ -131,14 +131,14 @@ func (r *CompanionGCReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 		if err := writer.DeleteConfigMap(ctx, req.Namespace, req.Name); err != nil {
 			return ctrl.Result{}, fmt.Errorf("companion-gc: delete ConfigMap %q: %w", req.Name, err)
 		}
-		if err := writer.DeleteResourceBinding(ctx, req.Namespace, req.Name+"-configmap"); err != nil {
+		if err := writer.DeleteResourceBinding(ctx, req.Namespace, companionRBName(req.Name, kindConfigMap)); err != nil {
 			return ctrl.Result{}, fmt.Errorf("companion-gc: delete ConfigMap RB %q: %w", req.Name, err)
 		}
 	case kindSecret:
 		if err := writer.DeleteSecret(ctx, req.Namespace, req.Name); err != nil {
 			return ctrl.Result{}, fmt.Errorf("companion-gc: delete Secret %q: %w", req.Name, err)
 		}
-		if err := writer.DeleteResourceBinding(ctx, req.Namespace, req.Name+"-secret"); err != nil {
+		if err := writer.DeleteResourceBinding(ctx, req.Namespace, companionRBName(req.Name, kindSecret)); err != nil {
 			return ctrl.Result{}, fmt.Errorf("companion-gc: delete Secret RB %q: %w", req.Name, err)
 		}
 	}

internal/controller/orphan_rb_controller.go

@@ -127,7 +127,7 @@ func (r *OrphanRBReconciler) isInScope(rb *karmadaworkv1alpha2.ResourceBinding)
 		return false
 	}
 	name := rb.Name
-	return strings.HasSuffix(name, "-configmap") || strings.HasSuffix(name, "-secret")
+	return strings.HasSuffix(name, rbSuffixConfigMap) || strings.HasSuffix(name, rbSuffixSecret)
 }
 
 // companionFromRBName extracts the companion object name and kind from a
@@ -139,15 +139,24 @@ func (r *OrphanRBReconciler) isInScope(rb *karmadaworkv1alpha2.ResourceBinding)
 //	"wd-foo-workloaddeployment" → ("", "", false)  // not a companion RB
 func companionFromRBName(rbName string) (companionName, kind string, ok bool) {
 	switch {
-	case strings.HasSuffix(rbName, "-configmap"):
-		return strings.TrimSuffix(rbName, "-configmap"), kindConfigMap, true
-	case strings.HasSuffix(rbName, "-secret"):
-		return strings.TrimSuffix(rbName, "-secret"), kindSecret, true
+	case strings.HasSuffix(rbName, rbSuffixConfigMap):
+		return strings.TrimSuffix(rbName, rbSuffixConfigMap), kindConfigMap, true
+	case strings.HasSuffix(rbName, rbSuffixSecret):
+		return strings.TrimSuffix(rbName, rbSuffixSecret), kindSecret, true
 	default:
 		return "", "", false
 	}
 }
 
+// companionRBName returns the Karmada ResourceBinding name for a companion object
+// of the given kind. It is the inverse of companionFromRBName.
+func companionRBName(objectName, kind string) string {
+	if kind == kindSecret {
+		return objectName + rbSuffixSecret
+	}
+	return objectName + rbSuffixConfigMap
+}
+
 // isOrphaned returns true when the hub companion is fully absent. A companion
 // with a deletionTimestamp is considered NOT orphaned — the deletion is in
 // progress and Karmada's cascade (or Component 3's explicit RB delete) is
@@ -196,7 +205,7 @@ func (r *OrphanRBReconciler) SetupWithManager(mgr manager.Manager) error {
 					return false
 				}
 				name := obj.GetName()
-				return strings.HasSuffix(name, "-configmap") || strings.HasSuffix(name, "-secret")
+				return strings.HasSuffix(name, rbSuffixConfigMap) || strings.HasSuffix(name, rbSuffixSecret)
 			})),
 		).
 		Named("orphan-rb").

internal/controller/referenceddata_controller.go

@@ -63,6 +63,13 @@ const (
 	// referenceddata.ObjectRef to avoid repeated string literals.
 	kindConfigMap = "ConfigMap"
 	kindSecret    = "Secret"
+
+	// rbSuffixConfigMap and rbSuffixSecret are the companion ResourceBinding name
+	// suffixes. Karmada names namespace-scoped RBs "{objectName}-{kindLowercase}";
+	// companionRBName builds these and companionFromRBName parses them, so the wire
+	// format has one source of truth.
+	rbSuffixConfigMap = "-configmap"
+	rbSuffixSecret    = "-secret"
 )
 
 // companionWriter is the abstraction that the controller uses to materialise
@@ -1162,7 +1169,7 @@ func (r *ReferencedDataController) releaseOneCompanion(
 		// "{companionName}-configmap". IgnoreNotFound because Karmada may have
 		// already cascaded the deletion.
 		if cmDeleted {
-			if err := writer.DeleteResourceBinding(ctx, namespace, companionName+"-configmap"); err != nil {
+			if err := writer.DeleteResourceBinding(ctx, namespace, companionRBName(companionName, kindConfigMap)); err != nil {
 				return fmt.Errorf("referenceddata: delete ResourceBinding for ConfigMap %q: %w", companionName, err)
 			}
 		}
@@ -1205,7 +1212,7 @@ func (r *ReferencedDataController) releaseOneCompanion(
 	// The RB name follows the Karmada binding-controller convention:
 	// "{companionName}-secret".
 	if secretDeleted {
-		if err := writer.DeleteResourceBinding(ctx, namespace, companionName+"-secret"); err != nil {
+		if err := writer.DeleteResourceBinding(ctx, namespace, companionRBName(companionName, kindSecret)); err != nil {
 			return fmt.Errorf("referenceddata: delete ResourceBinding for Secret %q: %w", companionName, err)
 		}
 	}