fix(lint): extract goconst constants and gofmt the bundled controller tests

Make the cherry-picked instanceType-sizing and blocking-reason tests
lint-clean: hoist the repeated "datumcloud/d1-standard-2", "app", and
"test/image:latest" literals into named constants (goconst) and apply
gofmt. No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: scotwells

internal/controller/instance_controller.go

@@ -96,6 +96,10 @@ const (
 	reasonNetworkFailedToCreate = "NetworkFailedToCreate"
 )
 
+// instanceTypeD1Standard2 is the platform instance type name for the
+// 1 vCPU / 2 GiB size used as the catalog baseline for quota accounting.
+const instanceTypeD1Standard2 = "datumcloud/d1-standard-2"
+
 // instanceTypeResources holds the vCPU and memory for a named instance type.
 type instanceTypeResources struct {
 	// CPUMillicores is the number of CPU millicores (1000 = 1 vCPU).
@@ -114,7 +118,7 @@ type instanceTypeResources struct {
 // provisioning; that mapping does not define the quota size here.) When new
 // instance types are added, add them here with their vCPU/memory values.
 var instanceTypeCatalog = map[string]instanceTypeResources{
-	"datumcloud/d1-standard-2": {
+	instanceTypeD1Standard2: {
 		CPUMillicores: 1000, // 1 vCPU
 		MemoryMiB:     2048, // 2 GiB
 	},

internal/controller/instance_controller_test.go

@@ -1625,6 +1625,12 @@ func TestQuotaPendingRequeueAfter(t *testing.T) {
 	}
 }
 
+// Shared literals for the instance-sizing / blocking-reason tests below
+// (extracted to satisfy goconst).
+const (
+	testContainerName  = "app"
+	testContainerImage = "test/image:latest"
+)
 
 // TestReconcileInstanceReadyCondition_ProviderSubConditionSurfacing verifies
 // that provider-set sub-condition reasons (e.g. ImageUnavailable written by the
@@ -1950,11 +1956,11 @@ func TestResolveInstanceResources(t *testing.T) {
 	}
 
 	tests := []struct {
-		name            string
-		instance        *computev1alpha.Instance
-		wantCPU         int64
-		wantMem         int64
-		wantResolved    bool
+		name         string
+		instance     *computev1alpha.Instance
+		wantCPU      int64
+		wantMem      int64
+		wantResolved bool
 	}{
 		{
 			// Common production case: instanceType only, no explicit limits.
@@ -1965,7 +1971,7 @@ func TestResolveInstanceResources(t *testing.T) {
 				Spec: computev1alpha.InstanceSpec{
 					Runtime: computev1alpha.InstanceRuntimeSpec{
 						Resources: computev1alpha.InstanceRuntimeResources{
-							InstanceType: "datumcloud/d1-standard-2",
+							InstanceType: instanceTypeD1Standard2,
 						},
 					},
 				},
@@ -1982,13 +1988,13 @@ func TestResolveInstanceResources(t *testing.T) {
 				Spec: computev1alpha.InstanceSpec{
 					Runtime: computev1alpha.InstanceRuntimeSpec{
 						Resources: computev1alpha.InstanceRuntimeResources{
-							InstanceType: "datumcloud/d1-standard-2",
+							InstanceType: instanceTypeD1Standard2,
 						},
 						Sandbox: &computev1alpha.SandboxRuntime{
 							Containers: []computev1alpha.SandboxContainer{
 								{
-									Name:      "app",
-									Image:     "test/image:latest",
+									Name:      testContainerName,
+									Image:     testContainerImage,
 									Resources: makeContainerResources(cpu500m, mem256Mi),
 								},
 								{
@@ -2015,8 +2021,8 @@ func TestResolveInstanceResources(t *testing.T) {
 						Sandbox: &computev1alpha.SandboxRuntime{
 							Containers: []computev1alpha.SandboxContainer{
 								{
-									Name:      "app",
-									Image:     "test/image:latest",
+									Name:      testContainerName,
+									Image:     testContainerImage,
 									Resources: makeContainerResources(cpu1, mem512Mi),
 								},
 							},
@@ -2087,13 +2093,13 @@ func TestResolveInstanceResources(t *testing.T) {
 				Spec: computev1alpha.InstanceSpec{
 					Runtime: computev1alpha.InstanceRuntimeSpec{
 						Resources: computev1alpha.InstanceRuntimeResources{
-							InstanceType: "datumcloud/d1-standard-2",
+							InstanceType: instanceTypeD1Standard2,
 						},
 						Sandbox: &computev1alpha.SandboxRuntime{
 							Containers: []computev1alpha.SandboxContainer{
 								{
-									Name:  "app",
-									Image: "test/image:latest",
+									Name:  testContainerName,
+									Image: testContainerImage,
 									// No Resources.Limits set — common for UKC workloads.
 								},
 							},
@@ -2158,7 +2164,7 @@ func TestReconcileQuotaClaim_RequestsIncludeVCPUsAndMemory(t *testing.T) {
 			Runtime: computev1alpha.InstanceRuntimeSpec{
 				Resources: computev1alpha.InstanceRuntimeResources{
 					// No Requests, no container Limits — catalog must supply the values.
-					InstanceType: "datumcloud/d1-standard-2",
+					InstanceType: instanceTypeD1Standard2,
 				},
 			},
 			NetworkInterfaces: []computev1alpha.InstanceNetworkInterface{},