fix(lint): dedupe test fixture constants for goconst

Extract shared WorkloadDeployment test fixtures (cityCode, wdControllerTestUID)
and the quota-denied message into package-level constants so goconst no longer
flags repeated string literals across the controller test files.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: scotwells

internal/controller/instance_controller_test.go

@@ -46,6 +46,9 @@ const (
 	testQuotaAPIGroup          = "quota.miloapis.com"
 	testQuotaResource          = "resourceclaims"
 	kindWorkloadDeploymentTest = "WorkloadDeployment" // mirrors kindWorkloadDeployment
+
+	// testMsgQuotaExceeded is the quota-denied message used across quota tests.
+	testMsgQuotaExceeded = "Quota exceeded for project"
 )
 
 // newTestScheme builds a runtime.Scheme with the types needed for instance reconcile tests.
@@ -345,7 +348,7 @@ func TestReconcileInstanceReadyConditionWithQuota(t *testing.T) {
 							Type:               computev1alpha.InstanceQuotaGranted,
 							Status:             metav1.ConditionFalse,
 							Reason:             computev1alpha.InstanceQuotaGrantedReasonQuotaExceeded,
-							Message:            "Quota exceeded for project",
+							Message:            testMsgQuotaExceeded,
 							LastTransitionTime: metav1.Now(),
 						},
 						{
@@ -370,7 +373,7 @@ func TestReconcileInstanceReadyConditionWithQuota(t *testing.T) {
 				Type:    computev1alpha.InstanceReady,
 				Status:  metav1.ConditionFalse,
 				Reason:  computev1alpha.InstanceProgrammedReasonPendingQuota,
-				Message: "Quota exceeded for project",
+				Message: testMsgQuotaExceeded,
 			},
 		},
 		{

internal/controller/instance_referenced_data_test.go

@@ -751,7 +751,7 @@ func TestFederated_QuotaAndSourceNotFound_SourceNotFoundWins(t *testing.T) {
 			Type:               computev1alpha.InstanceQuotaGranted,
 			Status:             metav1.ConditionFalse,
 			Reason:             computev1alpha.InstanceQuotaGrantedReasonQuotaExceeded,
-			Message:            "Quota exceeded for project",
+			Message:            testMsgQuotaExceeded,
 			ObservedGeneration: 1,
 			LastTransitionTime: metav1.Now(),
 		},

internal/controller/workloaddeployment_controller_test.go

@@ -17,10 +17,14 @@ import (
 )
 
 const (
-	// wdControllerTestName / wdControllerTestNS are shared fixtures for the
-	// WorkloadDeployment controller unit tests.
+	// wdControllerTestName / wdControllerTestNS / wdControllerTestUID are shared
+	// fixtures for the WorkloadDeployment controller unit tests.
 	wdControllerTestName = "test-wd"
 	wdControllerTestNS   = "default"
+	wdControllerTestUID  = "wd-uid-test"
+
+	// cityCode is the shared CityCode fixture for WorkloadDeployment tests.
+	cityCode = "DFW"
 
 	// testMsgConfigMapNotFound is a representative terminal referenced-data
 	// message used across the Available-rollup unit tests.
@@ -46,14 +50,14 @@ func TestReconcileInstanceGates_NilController_DoesNotPanic(t *testing.T) {
 	// Build a deployment with a minimal template so ComputeHash produces a stable hash.
 	deployment := &computev1alpha.WorkloadDeployment{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      "test-wd",
-			Namespace: "default",
-			UID:       "wd-uid-test",
+			Name:      wdControllerTestName,
+			Namespace: wdControllerTestNS,
+			UID:       wdControllerTestUID,
 		},
 		Spec: computev1alpha.WorkloadDeploymentSpec{
-			CityCode:      "DFW",
+			CityCode:      cityCode,
 			PlacementName: testDefaultPlacement,
-			WorkloadRef:   computev1alpha.WorkloadReference{Name: "test-workload"},
+			WorkloadRef:   computev1alpha.WorkloadReference{Name: rdTestWorkloadName},
 			ScaleSettings: computev1alpha.HorizontalScaleSettings{
 				MinReplicas: 2,
 			},
@@ -74,9 +78,9 @@ func TestReconcileInstanceGates_NilController_DoesNotPanic(t *testing.T) {
 	instanceNilController := computev1alpha.Instance{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "instance-nil-controller",
-			Namespace: "default",
+			Namespace: wdControllerTestNS,
 			Labels: map[string]string{
-				computev1alpha.WorkloadDeploymentUIDLabel: "wd-uid-test",
+				computev1alpha.WorkloadDeploymentUIDLabel: wdControllerTestUID,
 			},
 		},
 		Status: computev1alpha.InstanceStatus{
@@ -98,9 +102,9 @@ func TestReconcileInstanceGates_NilController_DoesNotPanic(t *testing.T) {
 	instanceWithController := computev1alpha.Instance{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "instance-with-controller",
-			Namespace: "default",
+			Namespace: wdControllerTestNS,
 			Labels: map[string]string{
-				computev1alpha.WorkloadDeploymentUIDLabel: "wd-uid-test",
+				computev1alpha.WorkloadDeploymentUIDLabel: wdControllerTestUID,
 			},
 		},
 		Status: computev1alpha.InstanceStatus{
@@ -122,9 +126,9 @@ func TestReconcileInstanceGates_NilController_DoesNotPanic(t *testing.T) {
 	instanceReady := computev1alpha.Instance{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "instance-ready",
-			Namespace: "default",
+			Namespace: wdControllerTestNS,
 			Labels: map[string]string{
-				computev1alpha.WorkloadDeploymentUIDLabel: "wd-uid-test",
+				computev1alpha.WorkloadDeploymentUIDLabel: wdControllerTestUID,
 			},
 		},
 		Status: computev1alpha.InstanceStatus{
@@ -188,9 +192,9 @@ func TestReconcileInstanceGates_NilSpecController_DoesNotPanic(t *testing.T) {
 	t.Parallel()
 
 	deployment := &computev1alpha.WorkloadDeployment{
-		ObjectMeta: metav1.ObjectMeta{Name: "test-wd", Namespace: "default", UID: "wd-uid-test"},
+		ObjectMeta: metav1.ObjectMeta{Name: wdControllerTestName, Namespace: wdControllerTestNS, UID: wdControllerTestUID},
 		Spec: computev1alpha.WorkloadDeploymentSpec{
-			CityCode:      "DFW",
+			CityCode:      cityCode,
 			PlacementName: testDefaultPlacement,
 			WorkloadRef:   computev1alpha.WorkloadReference{Name: "test-workload"},
 			ScaleSettings: computev1alpha.HorizontalScaleSettings{MinReplicas: 1},
@@ -201,7 +205,7 @@ func TestReconcileInstanceGates_NilSpecController_DoesNotPanic(t *testing.T) {
 	// Spec.Controller intentionally nil — the network gate-clearing path runs
 	// (networkReady=true) and must skip this instance instead of panicking.
 	instanceNilSpecController := computev1alpha.Instance{
-		ObjectMeta: metav1.ObjectMeta{Name: "instance-nil-spec-controller", Namespace: "default"},
+		ObjectMeta: metav1.ObjectMeta{Name: "instance-nil-spec-controller", Namespace: wdControllerTestNS},
 	}
 
 	cl := newProjectFakeClient()

internal/controller/workloaddeployment_location_test.go

@@ -34,7 +34,6 @@ func newNetworkingScheme() *runtime.Scheme {
 func TestReconcileNetworks_PersistsLocation_WhenLocationFound(t *testing.T) {
 	t.Parallel()
 
-	const cityCode = "DFW"
 	const locationName = "loc-dfw-1"
 	const locationNamespace = "networking-system"
 
@@ -54,7 +53,7 @@ func TestReconcileNetworks_PersistsLocation_WhenLocationFound(t *testing.T) {
 	cl := fake.NewClientBuilder().WithScheme(s).WithObjects(location).Build()
 
 	deployment := &computev1alpha.WorkloadDeployment{
-		ObjectMeta: metav1.ObjectMeta{Name: "test-wd", Namespace: "default"},
+		ObjectMeta: metav1.ObjectMeta{Name: wdControllerTestName, Namespace: wdControllerTestNS},
 		Spec: computev1alpha.WorkloadDeploymentSpec{
 			CityCode: cityCode,
 			// No NetworkInterfaces — the function returns false,locationRef,nil
@@ -98,9 +97,9 @@ func TestReconcileNetworks_ReturnsNilLocation_WhenNoLocationFound(t *testing.T)
 	cl := fake.NewClientBuilder().WithScheme(s).WithObjects(otherLocation).Build()
 
 	deployment := &computev1alpha.WorkloadDeployment{
-		ObjectMeta: metav1.ObjectMeta{Name: "test-wd", Namespace: "default"},
+		ObjectMeta: metav1.ObjectMeta{Name: wdControllerTestName, Namespace: wdControllerTestNS},
 		Spec: computev1alpha.WorkloadDeploymentSpec{
-			CityCode: "DFW", // no matching Location
+			CityCode: cityCode, // no matching Location
 		},
 	}