test(controller): fix lint (gofmt + goconst) to green the CI Lint job

The Lint job had been red on the branch from pre-existing findings,
unrelated to the rename/quota work:
- gofmt: re-align a struct in the instance-sizing test.
- goconst: extract the repeated "datumcloud/d1-standard-2", "app", and
  "test/image:latest" literals into test constants.

Tests and lint both pass locally.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: scotwells

internal/controller/instance_controller_test.go

@@ -60,6 +60,12 @@ const (
 
 	// testMsgQuotaExceeded is the quota-denied message used across quota tests.
 	testMsgQuotaExceeded = "Quota exceeded for project"
+
+	// Catalog instance type, container name, and image used across the
+	// instance-mapper / sizing tests (extracted to satisfy goconst).
+	testCatalogInstanceType = "datumcloud/d1-standard-2"
+	testContainerName       = "app"
+	testContainerImage      = "test/image:latest"
 )
 
 // newTestScheme builds a runtime.Scheme with the types needed for instance reconcile tests.
@@ -2221,11 +2227,11 @@ func TestResolveInstanceResources(t *testing.T) {
 	}
 
 	tests := []struct {
-		name            string
-		instance        *computev1alpha.Instance
-		wantCPU         int64
-		wantMem         int64
-		wantResolved    bool
+		name         string
+		instance     *computev1alpha.Instance
+		wantCPU      int64
+		wantMem      int64
+		wantResolved bool
 	}{
 		{
 			// Common production case: instanceType only, no explicit limits.
@@ -2236,7 +2242,7 @@ func TestResolveInstanceResources(t *testing.T) {
 				Spec: computev1alpha.InstanceSpec{
 					Runtime: computev1alpha.InstanceRuntimeSpec{
 						Resources: computev1alpha.InstanceRuntimeResources{
-							InstanceType: "datumcloud/d1-standard-2",
+							InstanceType: testCatalogInstanceType,
 						},
 					},
 				},
@@ -2253,13 +2259,13 @@ func TestResolveInstanceResources(t *testing.T) {
 				Spec: computev1alpha.InstanceSpec{
 					Runtime: computev1alpha.InstanceRuntimeSpec{
 						Resources: computev1alpha.InstanceRuntimeResources{
-							InstanceType: "datumcloud/d1-standard-2",
+							InstanceType: testCatalogInstanceType,
 						},
 						Sandbox: &computev1alpha.SandboxRuntime{
 							Containers: []computev1alpha.SandboxContainer{
 								{
-									Name:      "app",
-									Image:     "test/image:latest",
+									Name:      testContainerName,
+									Image:     testContainerImage,
 									Resources: makeContainerResources(cpu500m, mem256Mi),
 								},
 								{
@@ -2286,8 +2292,8 @@ func TestResolveInstanceResources(t *testing.T) {
 						Sandbox: &computev1alpha.SandboxRuntime{
 							Containers: []computev1alpha.SandboxContainer{
 								{
-									Name:      "app",
-									Image:     "test/image:latest",
+									Name:      testContainerName,
+									Image:     testContainerImage,
 									Resources: makeContainerResources(cpu1, mem512Mi),
 								},
 							},
@@ -2358,13 +2364,13 @@ func TestResolveInstanceResources(t *testing.T) {
 				Spec: computev1alpha.InstanceSpec{
 					Runtime: computev1alpha.InstanceRuntimeSpec{
 						Resources: computev1alpha.InstanceRuntimeResources{
-							InstanceType: "datumcloud/d1-standard-2",
+							InstanceType: testCatalogInstanceType,
 						},
 						Sandbox: &computev1alpha.SandboxRuntime{
 							Containers: []computev1alpha.SandboxContainer{
 								{
-									Name:  "app",
-									Image: "test/image:latest",
+									Name:  testContainerName,
+									Image: testContainerImage,
 									// No Resources.Limits set — common for UKC workloads.
 								},
 							},
@@ -2429,7 +2435,7 @@ func TestReconcileQuotaClaim_RequestsIncludeVCPUsAndMemory(t *testing.T) {
 			Runtime: computev1alpha.InstanceRuntimeSpec{
 				Resources: computev1alpha.InstanceRuntimeResources{
 					// No Requests, no container Limits — catalog must supply the values.
-					InstanceType: "datumcloud/d1-standard-2",
+					InstanceType: testCatalogInstanceType,
 				},
 			},
 			NetworkInterfaces: []computev1alpha.InstanceNetworkInterface{},