Skip to content

Commit 37482ca

Browse files
authored
fix: rename machine account references to service accounts (#221)
## Summary - Updates assignable organization role configs (owner, editor, viewer) to reference renamed role names - Updates README feature list ## Changes | Old | New | |-----|-----| | `iam-machine-accounts-admin/editor/viewer` | `iam-service-accounts-admin/editor/viewer` | | `identity-machine-account-keys-admin/editor/viewer` | `identity-service-account-keys-admin/editor/viewer` | ## Test plan - [ ] Verify organization owners/editors/viewers can list and manage service accounts after deploy
2 parents 8a302c2 + 9692654 commit 37482ca

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ We support a growing collection of features that help make agentic and internet
9090
- Authoritative DNS
9191
- Domain resource tracking
9292
- Fine grained roles and permissions
93-
- Secrets & machine accounts
93+
- Secrets & service accounts
9494
- Activity logs
9595

9696
## Components

config/assignable-organization-roles/roles/datum-cloud-editor.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ spec:
2626
namespace: milo-system
2727
- name: notes-editor
2828
namespace: milo-system
29-
- name: identity-machine-account-keys-editor
29+
- name: identity-service-account-keys-editor
3030
namespace: milo-system
31-
- name: iam-machine-accounts-editor
31+
- name: iam-service-accounts-editor
3232
namespace: milo-system

config/assignable-organization-roles/roles/datum-cloud-owner.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ spec:
3030
namespace: milo-system
3131
- name: notes-admin
3232
namespace: milo-system
33-
- name: identity-machine-account-keys-admin
33+
- name: identity-service-account-keys-admin
3434
namespace: milo-system
35-
- name: iam-machine-accounts-admin
35+
- name: iam-service-accounts-admin
3636
namespace: milo-system

config/assignable-organization-roles/roles/datum-cloud-viewer.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ spec:
2828
namespace: milo-system
2929
- name: notes-viewer
3030
namespace: milo-system
31-
- name: identity-machine-account-keys-viewer
31+
- name: identity-service-account-keys-viewer
3232
namespace: milo-system
33-
- name: iam-machine-accounts-viewer
33+
- name: iam-service-accounts-viewer
3434
namespace: milo-system

0 commit comments

Comments
 (0)