feat(notification): add default email newsletter enrollment policy for new users#232
Merged
JoseSzycho merged 4 commits intoMay 26, 2026
Merged
Conversation
…ewsletter enrollment policy
mattdjenkinson
previously approved these changes
May 26, 2026
mattdjenkinson
previously approved these changes
May 26, 2026
As the previosuly all users group did not have a loops provider id, we had to delete the group and create a new one
mattdjenkinson
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notification.miloapis.comservice configuration underconfig/services/.ContactGroupEnrollmentPolicy(email-newsletter-enrollment-policy) that automatically enrolls all new User-backed Contacts into the email newsletter ContactGroup onContactCreated.config/services/kustomization.yaml.Details
The policy targets all contacts with
subjectKind: User, so every new user signup triggers enrollment into the configured ContactGroup without any manual intervention. The ContactGroup ref (emailnewsletter-contact-group-3a3ar9indefault) can be updated as needed.This depends on the
ContactGroupEnrollmentPolicyCRD and controller shipped in milo#603.Test plan
kustomize build config/servicesrenders cleanly with the new component.ContactGroupMembershipfor the newsletter group.🤖 Generated with Claude Code
Related to: