fix: persist tokens after refresh#66
Merged
Merged
Conversation
We were encountering an issue with users getting error messages after they've refreshed their access token. I was able to trace this down to the new access token and refresh token not being persisted in the keyring after a refresh occurred. This was resulting in an invalid refresh token error because the previous refresh token that existed in the keychain was revoked after a new token was issued. I also adjusted the error messaging so the user will be given a friendly error message if the refresh token is not valid and they need to re-authenticate.
scotwells
requested review from
JoseSzycho,
OscarLlamas6,
cc-datum,
drewr,
ecv,
gianarb and
zachsmith1
January 17, 2026 18:10
ecv
approved these changes
Jan 17, 2026
zachsmith1
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were encountering an issue with users getting error messages after they've refreshed their access token. Our access tokens are valid for 12 hours. Trying to use
datumctlafter the access token expired resulted in my token being refreshed but subsequent commands failing with an invalid refresh token error.I was able to trace this down to the new access token and refresh token not being persisted in the keyring after a refresh occurred. This was resulting in an invalid refresh token error because the previous refresh token that existed in the keychain was revoked after a new token was issued.
I fixed this by introducing a new TokenSource that automatically refreshes tokens and persists the updated tokens back into the keychain.
Other changes:
get-tokencommand to use the new token source