chore: add controller/reconcile/frr tests, update review plan#120
Open
privateip wants to merge 7 commits into
Open
chore: add controller/reconcile/frr tests, update review plan#120privateip wants to merge 7 commits into
privateip wants to merge 7 commits into
Conversation
privateip
force-pushed
the
refactor/galactic-router-replace-agent
branch
from
b87216d to
a653dc1
Compare
…time) Replace the gRPC-based galactic-agent DaemonSet with a controller-runtime based galactic-router. Key changes: - Remove internal/agent, internal/bootstrap, internal/gobgp packages - Add internal/controller with BGPRouter, BGPPeer, BGPAdvertisement, BGPPolicy, Secret, Node reconcilers - Add internal/reconcile for CRD-to-DesiredRouter translation - Add internal/runtime with RuntimeFactory pattern (GoBGP tenant, FRR fabric stub) - Add internal/model for internal BGP types and internal/hash for change detection - Update deployment manifests, Dockerfile, containerlab config, and docs - Switch health probes to gRPC on port 5000; remove HTTP health and webhook ports - GoBGP starts lazily on first BGPRouter reconcile (listenPort=-1, outbound-only) - Hash-based no-op suppression prevents redundant GoBGP Apply calls
privateip
force-pushed
the
refactor/galactic-router-replace-agent
branch
from
a653dc1 to
efc8cb5
Compare
- Replace galactic-agent with galactic-router container image - Replace BGPInstance/BGPPeer CRDs with BGPRouter/BGPPeer/BGPAdvertisement - Replace infra cluster with dfw cluster (three-region: dfw, iad, sjc) - Replace infra route reflector with iad-worker-rr node - Remove cosmos operator deployment from containerlab - Update NAD configs to use galacticRouter instead of gobgp - Add BGP CRD patches to fix ASN maximum for kubebuilder v0.18.0 - Update all documentation, Taskfile, and scripts accordingly
privateip
force-pushed
the
refactor/galactic-router-replace-agent
branch
from
b92bc59 to
e634f6c
Compare
Replaces the ErrEVPNNotImplemented stub with a real implementation that builds and advertises EVPN Type 5 IP Prefix routes for each SRv6 endpoint prefix in a BGPAdvertisement. The route distinguisher is derived from the BGPRouter's routerID (Type 1 IP-address:0), the MpReachNLRI next-hop is the node's primary IPv6 address, and route target communities are parsed from the advertisement's communities field. Withdrawal is also supported via b.DeletePath. Also adds a configurable BGP_LISTEN_PORT environment variable to galactic-router so the tenant GoBGP instance can bind on port 1790 (port 179 is occupied by the FRR underlay on each worker node). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…ions Update cosmos dependency to v0.0.0-20260622211233-0e38bdf25eac (PR #48) which replaces individual FSM conditions (SessionIdle, SessionConnect, etc.) with a consolidated Ready/Accepted condition model. - Replace setPeerSessionState + setPeerCondition with setPeerReadyCondition that sets a single Ready condition using bgpv1alpha1.ConditionTypeReady - Remove unused FSM condition constants (SessionIdle..SessionEstablished) - Remove dead code: fsmConditions slice, fsmStateToCondition map - Update review-plan.md: mark Phase 3.2 and 3.3 as DONE Co-Authored-By: Claude <noreply@anthropic.com>
…nstants - Add controller_test.go: indexes, enqueue helpers, node-to-router mapping, condition helpers (1015 lines) - Add reconcile_test.go: BuildDesiredRouter, gatherPeers, gatherPolicies, AFI/timer/validation tests (1163 lines) - Add frr_test.go: FRR stub tests (60 lines) - Update review-plan.md: mark all phases DONE, add Phase 8 for new tests - Add Reason* constants to status.go for BGP session state reasons
privateip
changed the title
privateip
changed the title
privateip
changed the title
Replace BGP unnumbered (link-local) underlay peering with numbered IPv6 /64 subnets between workers and transit routers. Add BGP_LOCAL_ADDRESS env var to the galactic-router overlay DaemonSet so GoBGP pins the TCP source address to the node SRv6 loopback. Underlay: configure numbered IPv6 links and route-maps to set source address on FRR BGP advertisements (SRv6 SID/forwarding prefixes). GoBGP runtime: accept localAddress in NewRuntimeFactory, propagate to peerFromDesired, set Transport.LocalAddress on every peer. Docs: update containerlab README to reflect numbered links.
privateip
force-pushed
the
refactor/galactic-router-replace-agent
branch
from
15fb427 to
f96f5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final commit for the galactic-router rewrite branch. Adds comprehensive test coverage for controllers, reconcile logic, and the FRR stub, and updates the review plan to mark all phases complete.
Changes
enqueueRoutersForTarget,nodeToRouterRequests, and all condition helper functionsBuildDesiredRouter,gatherPeers,gatherPolicies, AFI/SAFI validation, timer validation,resolveNodeIPv6, and peer/policy router matchingReason*constants for BGP session state reason stringsVerification
go build ./...— zero errorsgo test ./internal/cni/,./internal/reconcile/,./internal/controller/,./internal/hash/— all passgo vet ./...— zero warningstask lint— 0 issuesgo fmt ./...— no unformatted filesReview Plan Status
All original review plan phases (1-7) are complete. This commit closes Phase 8 by committing the new test files for review. See docs/review-plan.md for full details.