fix: deduplicate VRF/host-interface checks in cmdCheck and cmdStatus#179
Merged
Conversation
Extract the duplicated VRF existence and host-interface existence checks shared between cmdCheck and cmdStatus into a single checkNodeLevelState helper. Both operations previously ran the same vrf.Exists() + netlink.LinkByName() sequence with identical error formatting, creating a maintenance risk for future drift. - Extract checkNodeLevelState helper that validates VRF and host interface existence, returning the host interface name and accumulated errors - Replace inline VRF/host checks in cmdCheck with a call to the helper - Replace inline VRF/host checks in cmdStatus with a call to the helper - Preserve hostName return value in cmdCheck for subsequent prevResult validation without duplicating GenerateInterfaceNameHost fixes #168
scotwells
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the duplicated VRF existence and host-interface existence checks shared between cmdCheck and cmdStatus into a single checkNodeLevelState helper. Both operations previously ran the same vrf.Exists() + netlink.LinkByName() sequence with identical error formatting, creating a maintenance risk for future drift.
fixes #168