fix: protect cleanupContainerNetnsrom deleting non-veth interfaces #180
Merged
Conversation
The cleanupContainerNetns function in the galactic-cni plugin deleted any interface matching the expected name without verifying it was the veth endpoint created by this plugin. If another tool or race condition created an interface with the same name, it could be accidentally removed, breaking network connectivity for an unrelated workload. - Add a type assertion to verify the link is a *netlink.Veth before deletion - Return a descriptive error when a non-veth interface is found at the expected name - Document the veth-only deletion behavior in the function comment - Add integration tests covering non-veth rejection, idempotent missing-interface handling, and successful veth cleanup fixes #159
scotwells
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanupContainerNetns function in the galactic-cni plugin deleted any interface matching the expected name without verifying it was the veth endpoint created by this plugin. If another tool or race condition created an interface with the same name, it could be accidentally removed, breaking network connectivity for an unrelated workload.
fixes #159