fix: make ConfigureInterfaceSysctls tolerate missing sysctl entries#182
Merged
Conversation
ConfigureInterfaceSysctls previously returned an error whenever any sysctl write failed, which caused VRF creation to fail entirely on nodes running minimal or container kernels where proxy_arp and proxy_ndp entries may not exist. This change makes it match ConfigureTapSysctls behavior by silently skipping missing entries and logging a warning instead. - Skip sysctl write errors instead of returning them, matching ConfigureTapSysctls behavior - Log failed sysctl sets at WARN level for observability without failing the caller - Add package-level logger variable to enable testable log verification - Add unit tests for nonexistent interface scenarios and settings completeness fixes #161
scotwells
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigureInterfaceSysctls previously returned an error whenever any sysctl write failed, which caused VRF creation to fail entirely on nodes running minimal or container kernels where proxy_arp and proxy_ndp entries may not exist. This change makes it match ConfigureTapSysctls behavior by silently skipping missing entries and logging a warning instead.
fixes #161