fix: validate SRv6Locator format in parseConf#183
Merged
Conversation
Add validation for the srv6_locator CNI config field in parseConf so malformed values fail fast at config parse time, before any kernel state is created. This prevents late-stage failures deep in the stack that can leave orphaned VRF, veth, and route state. - Add isValidSRv6Locator helper that checks for valid IPv6 CIDR prefix with mask length <= 64 - Call the validator in parseConf after VPC/VPCAttachment checks, before any kernel operations - Allow empty or missing srv6_locator since setupSRv6Ingress is a no-op for empty values - Add unit tests covering valid/invalid srv6_locator inputs including IPv4 rejection, mask overflow, and non-CIDR strings fixes #160
scotwells
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for the srv6_locator CNI config field in parseConf so malformed values fail fast at config parse time, before any kernel state is created. This prevents late-stage failures deep in the stack that can leave orphaned VRF, veth, and route state.
fixes #160