fix: validate prevResult from preceding CNI plugin#185
Merged
Conversation
scotwells
previously approved these changes
Jul 1, 2026
scotwells
left a comment
scotwells
left a comment
Contributor
There was a problem hiding this comment.
Got merge conflicts. Changes look good
The galactic-cni plugin silently ignored prevResult from a preceding plugin in the CNI chain, leaving it blind to prior chain state. - Validate prevResult is parseable as a valid CNI result during config parsing, failing fast rather than operating on garbage state - Validate prevResult contains at least one interface or IP assignment during ADD, rejecting empty or structurally broken chain results - Wire validation into parseConf and cmdAdd so invalid prevResult causes immediate failure before any kernel resources are created - Add unit tests for parseConf, validatePrevResult, validatePrevResultAdd, and cmdAdd prevResult handling across valid, empty, and invalid cases fixes #157
scotwells
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The galactic-cni plugin silently ignored prevResult from a preceding plugin in the CNI chain, leaving it blind to prior chain state.
fixes #157