chore: add an explicit nodeTaintsPolicy#206
Merged
Merged
Conversation
mattdjenkinson
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The extension server Deployment uses a
topologySpreadConstraintsrule withmaxSkew: 1acrosskubernetes.io/hostname. During a rolling update, thestrategy is
maxSurge: 1 / maxUnavailable: 0, which temporarily requires onemore pod than the desired replica count (2 → 3).
On edge clusters that have a mix of general worker nodes and tainted
special-purpose nodes, the surge pod gets stuck
Pending. Kubernetes countsall nodes with the topology key when computing skew, including tainted nodes
the pod can never land on. With 2 workers (1 pod each) and 3 tainted nodes (0
pods each), the current skew is already 1. Adding the surge pod to either
worker would raise the skew to 2, exceeding
maxSkew: 1.The stuck pod causes the Deployment to enter
ProgressDeadlineExceeded, whichin turn keeps the Flux
nso-extension-serverkustomization in a failing healthcheck loop. Flux retries every hour, and each retry triggers an Envoy Gateway
xDS re-translation. If the extension server is slow or returns a partial
response during that push, Envoy briefly serves a config with no TPP routes
applied — producing a ~1-minute spike of
envoy_http_no_routeerrors on theHTTPS listener.
Fix
Add
nodeTaintsPolicy: Honorto the topology spread constraint. This tellsKubernetes to exclude nodes with untolerated taints from the skew calculation.
With only the 2 schedulable workers counted, the surge pod sees a skew of 0 (1
vs 1) and can schedule freely (1+1=2 vs 1, skew=1 ≤ maxSkew).
Requirements
nodeTaintsPolicyis GA since Kubernetes 1.33. Verify edge cluster version before deploying.