Skip to content

feat: registration api/controller for rdap/whois#63

Merged
zachsmith1 merged 27 commits into
mainfrom
feat/adjustRegistrationStatus
Oct 16, 2025
Merged

feat: registration api/controller for rdap/whois#63
zachsmith1 merged 27 commits into
mainfrom
feat/adjustRegistrationStatus

Conversation

@zachsmith1

@zachsmith1 zachsmith1 commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

This pull request makes significant improvements to how domain registration and status information are represented and managed in the API. The changes introduce a new, more detailed Registration struct to replace the older DomainRegistrarStatus, add support for authoritative nameservers and apex domain identification, and update the CRD and deepcopy logic accordingly. These updates make the domain API more expressive and future-proof, especially for handling RDAP/WHOIS data.

Domain Data Model Enhancements

  • Introduced a new Registration struct in domain_types.go that captures comprehensive domain registration details, including registrar/registry info, lifecycle dates, statuses, DNSSEC, contacts, and abuse contacts. The old DomainRegistrarStatus and DNSSECStatus structs were removed.
  • Added support for authoritative nameservers and apex domain identification in DomainStatus, including a new Nameserver struct and an Apex boolean.
  • Extended domain status conditions and reasons to track domain validity, including new constants for valid/invalid apex domain states.

CRD Updates

  • Updated the CRD YAML to reflect new fields for apex, nameservers, and registration, including detailed schema for nested objects (registrar, registry, contacts, DNSSEC, etc.).
  • Added autogenerated deepcopy methods for all new structs (Registration, RegistrarInfo, RegistryInfo, Nameserver, NameserverIP, ContactSet, Contact, AbuseContact, DNSSECInfo, DSRecord), and removed deepcopy logic for deprecated structs.

joshlreese
joshlreese previously approved these changes Oct 7, 2025
joshlreese
joshlreese previously approved these changes Oct 7, 2025
zachsmith1 and others added 2 commits October 8, 2025 15:53
joshlreese
joshlreese previously approved these changes Oct 14, 2025
joshlreese
joshlreese previously approved these changes Oct 15, 2025
@zachsmith1 zachsmith1 changed the title feat: enrich domain registration status feat: registration api/controller for rdap/whois Oct 16, 2025
@zachsmith1
zachsmith1 merged commit 518bd8d into main Oct 16, 2025
10 checks passed
@scotwells
scotwells deleted the feat/adjustRegistrationStatus branch February 10, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants