feat: registration api/controller for rdap/whois#63
Merged
Conversation
joshlreese
previously approved these changes
Oct 7, 2025
joshlreese
previously approved these changes
Oct 7, 2025
…ller refactor: adjust verification flow to support upcoming registration loop
joshlreese
previously approved these changes
Oct 14, 2025
…ller feat: wire domain controller with rdap registration
joshlreese
previously approved these changes
Oct 15, 2025
feat: whois reconcile loop for tlds not in rdap
joshlreese
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to how domain registration and status information are represented and managed in the API. The changes introduce a new, more detailed
Registrationstruct to replace the olderDomainRegistrarStatus, add support for authoritative nameservers and apex domain identification, and update the CRD and deepcopy logic accordingly. These updates make the domain API more expressive and future-proof, especially for handling RDAP/WHOIS data.Domain Data Model Enhancements
Registrationstruct indomain_types.gothat captures comprehensive domain registration details, including registrar/registry info, lifecycle dates, statuses, DNSSEC, contacts, and abuse contacts. The oldDomainRegistrarStatusandDNSSECStatusstructs were removed.DomainStatus, including a newNameserverstruct and anApexboolean.CRD Updates
Registration,RegistrarInfo,RegistryInfo,Nameserver,NameserverIP,ContactSet,Contact,AbuseContact,DNSSECInfo,DSRecord), and removed deepcopy logic for deprecated structs.