feat: whois reconcile loop for tlds not in rdap#67
Merged
Conversation
joshlreese
approved these changes
Oct 16, 2025
joshlreese
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Left a couple non-blocking questions.
joshlreese
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds WHOIS-based domain registration support as a fallback when RDAP registration information is unavailable or incomplete. It introduces new logic to discover the authoritative WHOIS server using IANA bootstrap, follows registry and registrar referrals, and parses WHOIS responses to populate domain registration details. The changes also include new helper functions for WHOIS parsing and comprehensive tests for the fallback and referral logic.
Domain registration protocol selection and fallback:
DomainReconcilerto select RDAP as the primary registration protocol and fall back to WHOIS if RDAP bootstrap reports no match, RDAP response is nil, or RDAP object is missing. The registration mapping now uses WHOIS parsing when needed.WHOIS support and parsing:
github.com/domainr/whoisand implemented thewhoisFetchAtHosthelper for performing WHOIS queries at specific hosts.fetchRegistrationWhois, which discovers the authoritative WHOIS server via IANA, follows registry and registrar referrals, and parses WHOIS responses to extract registration, registrar, abuse contact, DNSSEC, statuses, and contact information.findWhoisValueandparseTimeFlexfor robust WHOIS field extraction and flexible date parsing.Nameserver population logic:
Modified nameserver assignment to use RDAP nameservers when available, or resolve via DNS when using WHOIS or when RDAP data is missing. This ensures correct NS population regardless of the protocol used.
Controller and dependency wiring:
Added the
whoisFetchfunction field toDomainReconcilerand wired it during controller setup for dependency injection and testing.Testing and validation: