fix: requeue on now or in the past#69
Merged
Merged
Conversation
joshlreese
previously approved these changes
Oct 22, 2025
joshlreese
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how the domain controller handles requeueing when a scheduled "wake" time for verification is due or in the past, and adds targeted tests to ensure this behavior. The main change is to avoid using the deprecated
Requeueflag by always setting a minimal positiveRequeueAfterduration when the wake time is now or has already passed.Key changes include:
Controller logic improvements:
Reconcilemethod indomain_controller.goto return a minimal positiveRequeueAfter(1 second) instead of using the deprecatedRequeueflag when the wake time is now or in the past. This ensures the controller properly requeues without relying on deprecated behavior.Testing enhancements:
TestVerification_RequeueImmediate_WhenWakeDueOrPastto verify that the controller requeues immediately (withRequeueAfter = 1s) when the next verification attempt is due now.TestVerification_RequeueImmediate_WhenWakeInPastto check that the controller also requeues immediately when the next verification attempt was due in the past.