fix: floor positive sub-seconds to 1s#70
Merged
Merged
Conversation
joshlreese
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the domain verification controller logic to handle sub-second requeue intervals more robustly and ensures immediate verification attempts are scheduled correctly. It also adds a new test to verify the updated requeue behavior.
Verification requeue logic improvements:
domain_controller.go, the requeue logic now floors any sub-secondRequeueAftervalues to a minimum of 1 second, preventing zero-duration requeues that could cause issues.Testing enhancements:
TestVerification_RequeueFloorsSubSecondToOneSecondindomain_controller_test.goto verify that sub-second requeue intervals are correctly floored to 1 second.