Skip to content

fix: floor positive sub-seconds to 1s#70

Merged
zachsmith1 merged 1 commit into
mainfrom
fix/requeue
Oct 22, 2025
Merged

fix: floor positive sub-seconds to 1s#70
zachsmith1 merged 1 commit into
mainfrom
fix/requeue

Conversation

@zachsmith1

Copy link
Copy Markdown
Contributor

This pull request improves the domain verification controller logic to handle sub-second requeue intervals more robustly and ensures immediate verification attempts are scheduled correctly. It also adds a new test to verify the updated requeue behavior.

Verification requeue logic improvements:

  • In domain_controller.go, the requeue logic now floors any sub-second RequeueAfter values to a minimum of 1 second, preventing zero-duration requeues that could cause issues.
  • The controller now schedules the first verification attempt immediately when a new verification is required, ensuring prompt processing without waiting for an external trigger.

Testing enhancements:

  • Added TestVerification_RequeueFloorsSubSecondToOneSecond in domain_controller_test.go to verify that sub-second requeue intervals are correctly floored to 1 second.

@zachsmith1
zachsmith1 merged commit b7c879b into main Oct 22, 2025
10 checks passed
@scotwells
scotwells deleted the fix/requeue branch February 10, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants