chore: convert NotetypeAdapter to ViewBinding

Issue 11116

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/notetype/NotetypeAdapter.kt

@@ -17,14 +17,12 @@ package com.ichi2.anki.notetype
 
 import android.content.Context
 import android.view.LayoutInflater
-import android.view.View
 import android.view.ViewGroup
-import android.widget.Button
-import android.widget.TextView
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.ListAdapter
 import androidx.recyclerview.widget.RecyclerView
 import com.ichi2.anki.R
+import com.ichi2.anki.databinding.ItemManageNoteTypeBinding
 
 private val notetypeNamesAndCountDiff =
     object : DiffUtil.ItemCallback<ManageNoteTypeUiModel>() {
@@ -53,7 +51,7 @@ internal class NotetypesAdapter(
         viewType: Int,
     ): NotetypeViewHolder =
         NotetypeViewHolder(
-            rowView = layoutInflater.inflate(R.layout.item_manage_note_type, parent, false),
+            binding = ItemManageNoteTypeBinding.inflate(layoutInflater, parent, false),
             onDelete = onDelete,
             onRename = onRename,
             onEditCards = onEditCards,
@@ -69,31 +67,26 @@ internal class NotetypesAdapter(
 }
 
 internal class NotetypeViewHolder(
-    rowView: View,
+    private val binding: ItemManageNoteTypeBinding,
     onShowFields: (ManageNoteTypeUiModel) -> Unit,
     onEditCards: (ManageNoteTypeUiModel) -> Unit,
     onRename: (ManageNoteTypeUiModel) -> Unit,
     onDelete: (ManageNoteTypeUiModel) -> Unit,
-) : RecyclerView.ViewHolder(rowView) {
-    val name: TextView = rowView.findViewById(R.id.note_name)
-    val useCount: TextView = rowView.findViewById(R.id.note_use_count)
-    private val btnDelete: Button = rowView.findViewById(R.id.note_delete)
-    private val btnRename: Button = rowView.findViewById(R.id.note_rename)
-    private val btnEditCards: Button = rowView.findViewById(R.id.note_edit_cards)
-    private var mManageNoteTypeUiModel: ManageNoteTypeUiModel? = null
-    private val resources = rowView.context.resources
+) : RecyclerView.ViewHolder(binding.root) {
+    private var manageNoteTypeUiModel: ManageNoteTypeUiModel? = null
+    private val resources = binding.root.context.resources
 
     init {
-        rowView.setOnClickListener { mManageNoteTypeUiModel?.let(onShowFields) }
-        btnEditCards.setOnClickListener { mManageNoteTypeUiModel?.let(onEditCards) }
-        btnDelete.setOnClickListener { mManageNoteTypeUiModel?.let(onDelete) }
-        btnRename.setOnClickListener { mManageNoteTypeUiModel?.let(onRename) }
+        binding.root.setOnClickListener { manageNoteTypeUiModel?.let(onShowFields) }
+        binding.editCardsButton.setOnClickListener { manageNoteTypeUiModel?.let(onEditCards) }
+        binding.deleteNoteTypeButton.setOnClickListener { manageNoteTypeUiModel?.let(onDelete) }
+        binding.renameNoteTypeButton.setOnClickListener { manageNoteTypeUiModel?.let(onRename) }
     }
 
     fun bind(manageNoteTypeUiModel: ManageNoteTypeUiModel) {
-        this.mManageNoteTypeUiModel = manageNoteTypeUiModel
-        name.text = manageNoteTypeUiModel.name
-        useCount.text =
+        this.manageNoteTypeUiModel = manageNoteTypeUiModel
+        binding.noteName.text = manageNoteTypeUiModel.name
+        binding.noteUseCount.text =
             resources.getQuantityString(
                 R.plurals.model_browser_of_type,
                 manageNoteTypeUiModel.useCount,

AnkiDroid/src/main/res/layout/item_manage_note_type.xml

@@ -37,7 +37,7 @@
             android:layout_width="match_parent"
             android:layout_height="wrap_content" >
             <Button
-                android:id="@+id/note_edit_cards"
+                android:id="@+id/edit_cards_button"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 style="@style/Widget.Material3.Button.TextButton"
@@ -46,33 +46,33 @@
                 app:layout_constraintTop_toTopOf="parent"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintEnd_toStartOf="@id/note_rename"
+                app:layout_constraintEnd_toStartOf="@id/rename_note_type_button"
                 app:layout_constraintHorizontal_chainStyle="packed"
                 app:layout_constraintHorizontal_bias="0.0" />
 
             <com.google.android.material.button.MaterialButton
-                android:id="@+id/note_rename"
+                android:id="@+id/rename_note_type_button"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 style="@style/Widget.Material3.Button.TextButton"
                 android:textColor="?attr/colorAccent"
                 android:text="@string/model_browser_rename"
                 app:layout_constraintTop_toTopOf="parent"
                 app:layout_constraintBottom_toBottomOf="parent"
-                app:layout_constraintStart_toEndOf="@id/note_edit_cards"
+                app:layout_constraintStart_toEndOf="@id/edit_cards_button"
                 app:layout_constraintEnd_toStartOf="@id/spacer" />
 
             <android.widget.Space
                 android:id="@+id/spacer"
                 android:layout_width="0dp"
                 android:layout_height="0dp"
                 android:layout_weight="1"
-                app:layout_constraintStart_toEndOf="@id/note_rename"
-                app:layout_constraintEnd_toStartOf="@id/note_delete"
+                app:layout_constraintStart_toEndOf="@id/rename_note_type_button"
+                app:layout_constraintEnd_toStartOf="@id/delete_note_type_button"
                 />
 
             <com.google.android.material.button.MaterialButton
-                android:id="@+id/note_delete"
+                android:id="@+id/delete_note_type_button"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 style="@style/Widget.Material3.Button.TextButton"