refactor(card-browser): move options to repository

* Simplifies the ViewModel, it's getting large

Assisted-by: Claude Opus 4.7 - all

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/browser/BrowserOptionsRepository.kt

@@ -0,0 +1,70 @@
+/*
+ *  Copyright (c) 2026 David Allison <davidallisongithub@gmail.com>
+ *
+ *  This program is free software; you can redistribute it and/or modify it under
+ *  the terms of the GNU General Public License as published by the Free Software
+ *  Foundation; either version 3 of the License, or (at your option) any later
+ *  version.
+ *
+ *  This program is distributed in the hope that it will be useful, but WITHOUT ANY
+ *  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
+ *  PARTICULAR PURPOSE. See the GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License along with
+ *  this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.ichi2.anki.browser
+
+import android.content.SharedPreferences
+import androidx.core.content.edit
+import com.ichi2.anki.CollectionManager.withCol
+import com.ichi2.anki.model.CardsOrNotes
+import com.ichi2.anki.utils.ext.ignoreAccentsInSearch
+import kotlinx.coroutines.flow.MutableStateFlow
+import kotlinx.coroutines.flow.StateFlow
+import timber.log.Timber
+
+/**
+ * Source of truth for the values controlled by [com.ichi2.anki.dialogs.BrowserOptionsDialog]
+ */
+class BrowserOptionsRepository(
+    private val sharedPrefs: SharedPreferences,
+) {
+    val cardsOrNotes: StateFlow<CardsOrNotes>
+        field = MutableStateFlow(CardsOrNotes.CARDS)
+
+    val isTruncated: StateFlow<Boolean>
+        field = MutableStateFlow(sharedPrefs.getBoolean(PREF_IS_TRUNCATED, false))
+
+    val ignoreAccentsInSearch: StateFlow<Boolean>
+        field = MutableStateFlow(false)
+
+    /** Reads persisted values into the flows. Call once during ViewModel init. */
+    suspend fun load() {
+        cardsOrNotes.value = withCol { CardsOrNotes.fromCollection(this) }
+        ignoreAccentsInSearch.value = withCol { config.ignoreAccentsInSearch }
+    }
+
+    suspend fun setCardsOrNotes(value: CardsOrNotes) {
+        Timber.i("setting cards/notes mode to %s", value)
+        withCol { value.saveToCollection(this) }
+        cardsOrNotes.value = value
+    }
+
+    fun setIsTruncated(value: Boolean) {
+        Timber.d("setting truncated to %s", value)
+        sharedPrefs.edit { putBoolean(PREF_IS_TRUNCATED, value) }
+        isTruncated.value = value
+    }
+
+    suspend fun setIgnoreAccentsInSearch(value: Boolean) {
+        Timber.d("setting ignore accents in search to %s", value)
+        withCol { config.ignoreAccentsInSearch = value }
+        ignoreAccentsInSearch.value = value
+    }
+
+    companion object {
+        private const val PREF_IS_TRUNCATED = "isTruncated"
+    }
+}

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserViewModel.kt

@@ -20,7 +20,6 @@ import android.os.Bundle
 import android.os.Parcel
 import android.os.Parcelable
 import androidx.annotation.CheckResult
-import androidx.core.content.edit
 import androidx.core.os.BundleCompat
 import androidx.core.os.bundleOf
 import androidx.lifecycle.SavedStateHandle
@@ -82,7 +81,6 @@ import com.ichi2.anki.settings.Prefs
 import com.ichi2.anki.settings.PrefsRepository
 import com.ichi2.anki.utils.ext.currentCardBrowse
 import com.ichi2.anki.utils.ext.getCardOrNull
-import com.ichi2.anki.utils.ext.ignoreAccentsInSearch
 import com.ichi2.anki.utils.ext.setUserFlagForCards
 import kotlinx.coroutines.Deferred
 import kotlinx.coroutines.Job
@@ -141,6 +139,8 @@ class CardBrowserViewModel(
     preferences: SharedPreferencesProvider,
     val isFragmented: Boolean,
     val savedStateHandle: SavedStateHandle,
+    private val browserOptionsRepository: BrowserOptionsRepository =
+        BrowserOptionsRepository(preferences.sharedPrefs()),
     private val manualInit: Boolean = false,
 ) : ViewModel(),
     SharedPreferencesProvider by preferences {
@@ -168,8 +168,8 @@ class CardBrowserViewModel(
      * Whether the browser is working in Cards mode or Notes mode.
      * default: [CARDS]
      * */
-    private val flowOfCardsOrNotes = MutableStateFlow(CARDS)
-    val cardsOrNotes get() = flowOfCardsOrNotes.value
+    val flowOfCardsOrNotes: StateFlow<CardsOrNotes> = browserOptionsRepository.cardsOrNotes
+    val cardsOrNotes: CardsOrNotes get() = flowOfCardsOrNotes.value
 
     // card that was clicked (not marked)
     var currentCardId: CardId? = null
@@ -234,11 +234,10 @@ class CardBrowserViewModel(
             .map { it?.isNotEmpty() == true }
             .stateIn(viewModelScope, SharingStarted.Eagerly, initialValue = false)
 
-    val flowOfIsTruncated: MutableStateFlow<Boolean> =
-        MutableStateFlow(sharedPrefs().getBoolean("isTruncated", false))
-    val isTruncated get() = flowOfIsTruncated.value
+    val flowOfIsTruncated: StateFlow<Boolean> = browserOptionsRepository.isTruncated
+    val isTruncated: Boolean get() = flowOfIsTruncated.value
 
-    var shouldIgnoreAccents: Boolean = false
+    val shouldIgnoreAccents: Boolean get() = browserOptionsRepository.ignoreAccentsInSearch.value
 
     private val _selectedRows: MutableSet<CardOrNoteId> = Collections.synchronizedSet(LinkedHashSet())
 
@@ -499,16 +498,13 @@ class CardBrowserViewModel(
             }.launchIn(viewModelScope)
 
         viewModelScope.launch {
-            shouldIgnoreAccents = withCol { config.ignoreAccentsInSearch }
+            browserOptionsRepository.load()
 
             val initialDeckId = if (selectAllDecks) SelectableDeck.AllDecks else getInitialDeck()
             // PERF: slightly inefficient if the source was lastDeckId
             setSelectedDeck(initialDeckId)
             refreshBackendColumns()
 
-            val cardsOrNotes = withCol { CardsOrNotes.fromCollection(this@withCol) }
-            flowOfCardsOrNotes.update { cardsOrNotes }
-
             withCol {
                 sortTypeFlow.update { LegacySortType.fromCol(config, cardsOrNotes, prefs) }
                 reverseDirectionFlow.update { ReverseDirection.fromConfig(config) }
@@ -691,32 +687,11 @@ class CardBrowserViewModel(
             }
     }
 
-    fun setCardsOrNotes(newValue: CardsOrNotes) =
-        viewModelScope.launch {
-            Timber.i("setting mode to %s", newValue)
-            withCol {
-                // Change this to only change the preference on a state change
-                newValue.saveToCollection(this@withCol)
-            }
-            flowOfCardsOrNotes.update { newValue }
-        }
+    fun setCardsOrNotes(newValue: CardsOrNotes) = viewModelScope.launch { browserOptionsRepository.setCardsOrNotes(newValue) }
 
-    fun setTruncated(value: Boolean) {
-        viewModelScope.launch {
-            flowOfIsTruncated.emit(value)
-        }
-        sharedPrefs().edit {
-            putBoolean("isTruncated", value)
-        }
-    }
+    fun setTruncated(value: Boolean) = viewModelScope.launch { browserOptionsRepository.setIsTruncated(value) }
 
-    fun setIgnoreAccents(value: Boolean) {
-        Timber.d("Setting ignore accent in search to: $value")
-        viewModelScope.launch {
-            shouldIgnoreAccents = value
-            withCol { config.ignoreAccentsInSearch = value }
-        }
-    }
+    fun setIgnoreAccents(value: Boolean) = viewModelScope.launch { browserOptionsRepository.setIgnoreAccentsInSearch(value) }
 
     fun selectAll(): Job? {
         if (!_selectedRows.addAll(cards)) return null